market icon indicating copy to clipboard operation
market copied to clipboard

Download/compute does not honor infinite approval

Open kremalicious opened this issue 4 years ago • 2 comments

We use ocean.pool.buyDt() and that will always do a specific amount approval leading to the infinite amount user preference introduced with #640 being ignored.

Example use case when infinite approval is activated:

  1. user buys download asset which has a timeout set
  2. approves OCEAN once
  3. user buys same asset again after expired timeout, and then does NOT have to approve OCEAN again

Most likely needs some changes in ocean.js and over here in market we need to apply same logic as we use for Pool & Trade.

kremalicious avatar Sep 30 '21 10:09 kremalicious

Does it make sense to do this? Didn't we say we are freezing the market? Why focus on current version of ocean.js and not the next one? And yes this feature should exist in v4

mihaisc avatar Sep 30 '21 12:09 mihaisc

yeah good points, also wasn't sure so labeled as low priority. Would keep issue open so we know to check for it in v4 and we need to change the logic in market for consume/consume anyway

kremalicious avatar Oct 01 '21 10:10 kremalicious

Is this still an issue? From my memory this works ok. Plus we don't have pools anymore sooo...

mihaisc avatar Sep 29 '22 12:09 mihaisc