Download/compute does not honor infinite approval
We use ocean.pool.buyDt() and that will always do a specific amount approval leading to the infinite amount user preference introduced with #640 being ignored.
Example use case when infinite approval is activated:
- user buys download asset which has a timeout set
- approves OCEAN once
- user buys same asset again after expired timeout, and then does NOT have to approve OCEAN again
Most likely needs some changes in ocean.js and over here in market we need to apply same logic as we use for Pool & Trade.
Does it make sense to do this? Didn't we say we are freezing the market? Why focus on current version of ocean.js and not the next one? And yes this feature should exist in v4
yeah good points, also wasn't sure so labeled as low priority. Would keep issue open so we know to check for it in v4 and we need to change the logic in market for consume/consume anyway
Is this still an issue? From my memory this works ok. Plus we don't have pools anymore sooo...