market icon indicating copy to clipboard operation
market copied to clipboard

More transparency to metadata history

Open jamiehewitt15 opened this issue 3 years ago • 4 comments

Given that publishers can change the title, description and even author of their dataset it would be helpful to provide an audit trail of when each of these fields has been changed. Currently, the metadata history shows when changes have been made but it does not indicate which fields were changed.

It could be displayed on the asset detail page like below:

Metadata history - 2021-08-03_17-37

jamiehewitt15 avatar Aug 04 '21 09:08 jamiehewitt15

This would be great, always imagined some kind of diff view for the metadata changes. Like, clicking on one edit opens a modal and you see additions/removals in a combined diff view.

All theoretically possible as metadata is on-chain. Practically not sure we can get this through the subgraph when we get the contract events for displaying metadata history items, so needs to be tested. Otherwise we have to think of something in Aquarius possibly

kremalicious avatar Aug 04 '21 09:08 kremalicious

This is nice to have, but the effort at this point is way to big for it. Long story: We have 2 use cases :

  1. not encrypted (usual scenario for market) : we can just decompress using lzma and get the ddo

  2. encrypted : we can't decrypt because the key is only in aquarius

  3. An easy way would be to just show the whole ddo at that point in time, basically another details page (or maybe just the metadata component). A nicer way from a UX perspective would be to fetch the desired tx (the one the user clicked on ) and the previous one, decompress the and then convert them in json and compare them to see what change. After that we can display the user some nice information. We can do the comparison for all the history items as well but it will take a long time probably if there are multiple edits.

  4. No options here 😄 , carry on

mihaisc avatar Aug 04 '21 12:08 mihaisc

@jamiehewitt15 Is it something that is being worked on? Looks like a cool feature to have.

srikanthkaja avatar Nov 23 '21 03:11 srikanthkaja

Something similar will be developed. You will have the same list of history items but when you click on an item you will be redirected to a page with the asset preview at that point in time. So you will be able to open multiple previews and compare them. There will be no automatic comparison.

mihaisc avatar Nov 23 '21 07:11 mihaisc

Not sure when and if this will be done. When it's done in Aquarius we will reopen this.

mihaisc avatar Sep 29 '22 12:09 mihaisc