Highlights and clear button on edit UI

[EnzoVezzaro]

• Fixes #1244 .

Changes proposed in this PR:

• border outline when an input has changes
• added "search" type on text inputs for clear button support

Current (no feedback):

PR changes:

No change:

With change:

The clear "X" button shows up on hover.

WIP:

• [ ] add clear support to other input types
• [ ] testing outline in edit form

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
market	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 6, 2023 at 0:33AM (UTC)

[codeclimate[bot]]

Code Climate has analyzed commit 4262837b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 3.9% (0.0% change).

View more on Code Climate.

[mihaisc]

what is the status of this ? the pr mentioned as required was merged.

[EnzoVezzaro]

ready for review @jamiehewitt15 @bogdanfazakas

[codeclimate[bot]]

Code Climate has analyzed commit ae1dab88 and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1
Duplication	6

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 22.4% (0.0% change).

View more on Code Climate.

[jamiehewitt15]

I don't understand why the border colour changes to red? To me it looks like I have entered some invalid input. I feel like green would be a better choice?

[kremalicious]

added "search" type on text inputs for clear button support

This will only work in webkit & blink. And it's semantically completely wrong. You also used a -webkit- prefix where there should be no prefix usage at all. If you want a clear button in all browsers you actually have to build it for all browsers.

And as Jamie said, the pink outlined form field is kinda confusing as it's the only form field within the whole app behaving like this.

[mihaisc]

closing this, minor improvement, taking too much time