market icon indicating copy to clipboard operation
market copied to clipboard

adding UI for field files / links in edit form

Open EnzoVezzaro opened this issue 2 years ago • 2 comments

  • Fixes #1244 .

Changes proposed in this PR:

  • validation 'sample links' in edit form
Screenshot 2022-08-15 at 09 29 33
  • placeholder 'file url' during edit
Screenshot 2022-08-15 at 09 29 39

WIP:

  • [ ] on some assets, it doesn't get picked up

EnzoVezzaro avatar Aug 15 '22 13:08 EnzoVezzaro

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
market ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 11:05AM (UTC)

vercel[bot] avatar Aug 15 '22 13:08 vercel[bot]

Deploy Preview for market-oceanprotocol ready!

Name Link
Latest commit cf0c31fc7b81b97a277c13085b07cf375346a7d9
Latest deploy log https://app.netlify.com/sites/market-oceanprotocol/deploys/6348130d71d0990008827c2a
Deploy Preview https://deploy-preview-1655--market-oceanprotocol.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 12 '22 14:10 netlify[bot]

found one issue, if the asset you want to edit already has sample files, the submit button is always disabled even if you update the sample field or any of them, on the other side the submit button is always enabled on assets without sample files set, even if you have even touched or updated any form input fields.

https://user-images.githubusercontent.com/13447142/195508812-78725c38-68b8-4476-8ffd-dccd22db4ecb.mov

bogdanfazakas avatar Oct 13 '22 05:10 bogdanfazakas

found one issue, if the asset you want to edit already has sample files, the submit button is always disabled even if you update the sample field or any of them, on the other side the submit button is always enabled on assets without sample files set, even if you have even touched or updated any form input fields.

Screen.Recording.2022-10-13.at.08.13.21.mov

oh boy 😅 getting that validation to work properly was challenging 😂 please let me know if it needs more changes 👍🏽

EnzoVezzaro avatar Oct 13 '22 13:10 EnzoVezzaro

Code Climate has analyzed commit 52a69a1e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 4.0% (0.0% change).

View more on Code Climate.

codeclimate[bot] avatar Oct 17 '22 13:10 codeclimate[bot]

think we can merge this, just double checked latest changes and all seems to be in place

bogdanfazakas avatar Oct 25 '22 08:10 bogdanfazakas