oceanprotocol
Added new .sh file for Windows
Description
The start_ocean.sh file had a sudo command which doesnt work on Windows and only existed as a workaround for MacOS, so a new start_ocean_windows.sh file without this unnecessary command has been created.
Is this PR related with an open issue?
No.
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [x] Follows the code style of this project.
- [x] Tests Cover Changes
- [x] Documentation
thanks, but by duplicating almost all of the script code this would create double the work required for maintenance.
In general, using conditionals in the existing script would be a better strategy. Trying to get rid of that sudo altogether another possibility. And finally, this was never supposed to work with Windows, but only with its WSL layer for which everything should work, right? Barge is happily being used in multiple CI tests running against Windows in multiple repositories.
Barge is not being used against Windows, we have just some builds , but not the tests (that are using barge) . I've been using wsl 2 for more than a year without any issues
