barge icon indicating copy to clipboard operation
barge copied to clipboard

Update ganache-cli to EIP-1559-compatible hardfork

Open MantisClone opened this issue 3 years ago • 5 comments

Testing performed in the provider repo shows that EIP-1559 transactions submitted to ganache running in barge, fail with the following error:

"Method eth_maxPriorityFeePerGas not supported."

Currently, ganache is started with --hardfork istanbul option:

entrypoint: ["node", "/app/ganache-core.docker.cli.js", "--db", "./ganache_cache","--chainId","0x2324","--networkId","0x2324","--gasLimit","10000000000","--gasPrice","1","---hardfork","istanbul","--mnemonic","${GANACHE_MNEMONIC}"]

I believe upgrading to london or arrowGlacier will allow EIP-1559 transactions.

EDIT: We're already using the latest image from https://hub.docker.com/r/trufflesuite/ganache-cli/. It hasn't been updated in over a year so the latest supported hard fork is muirGlacier. Upgrading to support EIP-1559 transactions will likely involve changing docker image for ganache and is not as simple as I anticipated.

MantisClone avatar Dec 13 '21 15:12 MantisClone

Looks like arrowGlacier isn't supported, so I'll try london next.

ganache_1          | Error: Hardfork with name arrowGlacier not supported

MantisClone avatar Dec 13 '21 15:12 MantisClone

Hmm... london isn't supported either.

ganache_1          | Error: Hardfork with name london not supported

Maybe I need to upgrade ganache-core version first.

ganache_1          | Ganache CLI v6.12.2 (ganache-core: 2.13.2)

MantisClone avatar Dec 13 '21 15:12 MantisClone

We're already using the latest image from https://hub.docker.com/r/trufflesuite/ganache-cli/. It hasn't been updated in over a year so the latest supported hard fork is muirGlacier. Upgrading to support EIP-1559 transactions will likely involve changing docker image for ganache and is not as simple as I anticipated.

MantisClone avatar Dec 13 '21 15:12 MantisClone

We decided to delay upgrading to EIP-1559 transactions.

MantisClone avatar Dec 13 '21 15:12 MantisClone

From time to time, we should update our ganache version

LoznianuAnamaria avatar Jun 27 '22 13:06 LoznianuAnamaria

#339 (done) gets latest Ganache

trentmc avatar Dec 26 '22 11:12 trentmc