Dominik Schilling

Optimization results are not shown for translated media via Polylang

1

**Describe the bug** Just like WPML, Polylang has also a feature to duplicate media attachments. While the image is optimized the list table shows the results only for one of...

S3-Uploads may be incorrectly detected as active

1

**Describe the bug** It's possible to install S3-Uploads via Composer which provides an autoloader for all the classes. This means that any `class_exists()` check will always return true for `S3_Uploads\Plugin`....

Show a warning if a glossary entry isn't in a translation

2

The current glossary entries are only shown in a title attribute. I think we should also check a suggested translation against the glossary again and show a warning if a...

Follow-up to #144. - https://github.com/deliciousbrains/GlotPress/commit/7c3f4f3e34976e85d0c35143e50664a919e5da34#diff-e721e34903e6c80ce0bb483a0d6555b6R89, https://github.com/deliciousbrains/GlotPress/commit/7c3f4f3e34976e85d0c35143e50664a919e5da34#diff-5dd587a9394e83f43dd2764468e4d142R12, https://github.com/deliciousbrains/GlotPress/commit/7c3f4f3e34976e85d0c35143e50664a919e5da34#diff-c4239e7606696e35a13d1d0811859f71R118, and https://github.com/deliciousbrains/GlotPress/commit/7c3f4f3e34976e85d0c35143e50664a919e5da34#diff-92a24969795901f34d4b312bc8b03ec3R18 should be moved to a helper function - `$_POST['default_sort']` needs sanitization in [routes/profile.php](https://github.com/deliciousbrains/GlotPress/blob/7c3f4f3e34976e85d0c35143e50664a919e5da34/gp-includes/routes/profile.php#L22). We should probably move the list in [gp-templates/translations.php](https://github.com/deliciousbrains/GlotPress/blob/7c3f4f3e34976e85d0c35143e50664a919e5da34/gp-templates/translations.php#L125-L134)...

Exceptions are unhandled

1

PhpRedis can throw a [RedisException](https://github.com/phpredis/phpredis#class-redisexception) in case of connection issues. This may happen in the [get method](https://github.com/pressjitsu/pj-object-cache-red/blob/0c4d8618a0131ad3ad0f74ad24c1dd3f5bb82426/object-cache.php#L582) for example. I suggest [doing something like redis-cache](https://github.com/tillkruss/redis-cache/blob/a1358acf59e9919b6c54e810015de241ec0d8c31/includes/object-cache.php#L1003-L1009) does. Any thoughts on this?

Old releases are not deleted if colors is enabled for ls command

3

- Deployer version: 7.1.3 - Deployment OS: macOS I noticed that for a project the old releases were not deleted while `keep_releases` was set to 3. After some debugging I...

Fixes #1349. This fixes a deprecation notice in PHP 8: > PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in classes/class-log.php on line 217...

Don't generate unused rewrite rules for alerts post type

1

`register_post_type()` generates rewrite rules by default even if the post type isn't public. Two avoid this we can pass `'rewrite' => false`. Currently the `rewrite_rules` options also contains these rules:...

Passing `null` to `add_submenu_page()` as the first argument is causing various PHP deprecation warnings because WordPress expects the parent argument to be a string. The fix would be to just...

Remove deprecated save feature

4

Since #22 is a breaking change the next version would be 3.0 so I think it's safe to remove the deprecated save feature. Related: https://github.com/mrnocreativity/postcss-critical-split/issues/3