v3.ocaml.org-rescript icon indicating copy to clipboard operation
v3.ocaml.org-rescript copied to clipboard

Added World Map to Academic Excellence Page

Open shreyaswikriti opened this issue 3 years ago • 4 comments

Added World Map to Academic Excellence Page, presenting all universities with map marker. Used ReScript bindings for React-Leaflet. Used Dynamic Import functionality of NextJs with No SSR for leaflet rendering map in the browser. Fetched location data (latitude and longitude) from ood/academic_institution to mark all universities on the map. Screenshot from 2021-08-11 17-45-38

Modified relative paths:

https://v3-ocaml-org-git-BRANCH_NAME-ocaml.vercel.app/PATH/TO/PAGE

https://v3-ocaml-org-git-fork-FORK_NAME-BRANCH_NAME-ocaml.vercel.app/PATH/TO/PAGE

Contributor Pre-flight Checklist

  • [ ] Accessibility check - checked pa11y report for modified pages, observing new errors
  • [ ] Responsive check - visually inspected vercel preview, using responsive tool to toggle between desktop and mobile view
  • [ ] HTML review - use browser DOM/Page inspector to inspect generated HTML within <div id="__next>" element

shreyaswikriti avatar Aug 11 '21 13:08 shreyaswikriti

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ocaml/v3-ocaml-org/7htxCyHX7oWREA8R7iAAvajX3ey4
✅ Preview: https://v3-ocaml-org-git-fork-shreyaswikriti-acad-ocaml.vercel.app

vercel[bot] avatar Aug 11 '21 13:08 vercel[bot]

Amazing!

ghost avatar Aug 11 '21 21:08 ghost

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/ocaml/settings/billing.

vercel[bot] avatar Sep 06 '21 16:09 vercel[bot]

@shreyaswikriti I just pushed some changes to bring this PR up to date and update ood so the longitudes fixes are now in. Once we work out the vercel problem, this should be good to go. Thanks for the PR doing all of the leg work :))

patricoferris avatar Sep 06 '21 16:09 patricoferris