v2.ocaml.org
v2.ocaml.org copied to clipboard
Added discussion links
Issue Description
To display an external link to the discussion forum and add a link to the corresponding discussion at the bottom of each tutorial on the website.
Fixes #1504
Changes Made
After:
External link:
Discuss link at the bottom of each tutorial:
If this seems fine, I'll add the same link at the bottom of other tutorials also. :)
- Please check if the PR fulfills these requirements
- [x] PR is descriptively titled and links the original issue above
- [x] Before/after screenshots (if this is a layout change)
- [x] Details of which platforms the change was tested on (if this is a browser-specific change)
- [x] Context for what motivated the change (if this is a change to some content)
Hi @dldisha thanks for this PR.
In your description of it you say
add a link to the corresponding discussion at the bottom of each tutorial on the website
Unless I'm mistaken, it looks like you've only added it the main learn
page and the up_and_running
tutorial? Is this intentional?
Yes @patricoferris, because I first wanted a mentor to check my code changes as this is just a test(I guess). And if that all seems fine I'll do the same for each tutorial. Didn't want to pile up the wrong commits. So should I move forward with other tutorials?
@dldisha You can go ahead and add it to all tutorials :) Thanks!
@gs0510 Done! please check.
@dldisha Thanks! Can you rebase your PR against master to remove the conflicts? Thanks! :)