v2.ocaml.org icon indicating copy to clipboard operation
v2.ocaml.org copied to clipboard

Added discussion links

Open dldisha opened this issue 3 years ago • 5 comments

Issue Description

To display an external link to the discussion forum and add a link to the corresponding discussion at the bottom of each tutorial on the website.

Fixes #1504

Changes Made

After:

External link: Screenshot from 2021-04-17 03-20-52

Discuss link at the bottom of each tutorial: Screenshot from 2021-04-17 03-52-01

If this seems fine, I'll add the same link at the bottom of other tutorials also. :)

  • Please check if the PR fulfills these requirements
  • [x] PR is descriptively titled and links the original issue above
  • [x] Before/after screenshots (if this is a layout change)
  • [x] Details of which platforms the change was tested on (if this is a browser-specific change)
  • [x] Context for what motivated the change (if this is a change to some content)

dldisha avatar Apr 16 '21 22:04 dldisha

Hi @dldisha thanks for this PR.

In your description of it you say

add a link to the corresponding discussion at the bottom of each tutorial on the website

Unless I'm mistaken, it looks like you've only added it the main learn page and the up_and_running tutorial? Is this intentional?

patricoferris avatar Apr 19 '21 08:04 patricoferris

Yes @patricoferris, because I first wanted a mentor to check my code changes as this is just a test(I guess). And if that all seems fine I'll do the same for each tutorial. Didn't want to pile up the wrong commits. So should I move forward with other tutorials?

dldisha avatar Apr 19 '21 11:04 dldisha

@dldisha You can go ahead and add it to all tutorials :) Thanks!

gs0510 avatar Apr 21 '21 16:04 gs0510

@gs0510 Done! please check.

dldisha avatar Apr 21 '21 19:04 dldisha

@dldisha Thanks! Can you rebase your PR against master to remove the conflicts? Thanks! :)

gs0510 avatar Apr 22 '21 07:04 gs0510