v2.ocaml.org icon indicating copy to clipboard operation
v2.ocaml.org copied to clipboard

Detecting and deleting dead scripts

Open dldisha opened this issue 3 years ago • 2 comments

Issue Description

There are a couple of scripts in the codebase that seem to be dead code and don't have an impact on the development.

Fixes #1531

Changes Made

I have deleted all such scripts which are not being used for the development anymore. For resolving the issue, I first removed one script at a time and build the project again. If the build was successful without the script then that particular script is not being used for the development and is a dead code.

In total, I detected 7 such scripts that are dead code.

  • Please check if the PR fulfills these requirements
  • [x] PR is descriptively titled and links the original issue above
  • [x] Before/after screenshots (if this is a layout change)
  • [x] Details of which platforms the change was tested on (if this is a browser-specific change)
  • [x] Context for what motivated the change (if this is a change to some content)

dldisha avatar Apr 16 '21 20:04 dldisha

Thankyou @patricoferris for the review and the explanation. I'll study the scripts more deeply and get back to this asap.

dldisha avatar Apr 19 '21 11:04 dldisha

grep was quite helpful :) Helped me to undersnatd a lot about the file system.

Coming to the issue, I think we may not remove ocamlapplet.bash too because it is linked to Makefile.common; a template file being used to generate certain configuration and run a certain task if something goes wrong with automatic config.

dldisha avatar Apr 21 '21 21:04 dldisha