v2.ocaml.org icon indicating copy to clipboard operation
v2.ocaml.org copied to clipboard

Published 20 hours ago • verified publisher icon ocaml

Spring clean up: detect and delete dead scripts

Open pitag-ha opened this issue 3 years ago • 10 comments

There are a couple of scripts that seem to be dead code, e.g. ocamlapplet.bash and link_blog_doc_ext.sh. I propose that someone goes through all scripts in the script/ folder and finds and deletes the ones that don't have an impact anymore.

How

There are different ways to check if a script still has an impact (on the build). One option would be to build the page as is and save the result, then remove the script and build the page again, and then make a recursive diff on the two results.

Watch out

In the first run, you might wrongly detect scripts that are meant for development as dead code. Have a look if the scripts you detect are used for development.

pitag-ha avatar Apr 15 '21 14:04 pitag-ha

Hey @pitag-ha , I'm interested in working on this issue. Can I give it a try?

dldisha avatar Apr 15 '21 15:04 dldisha

@dldisha, sure, go ahead :)

pitag-ha avatar Apr 16 '21 09:04 pitag-ha

@pitag-ha, please review my code changes.

dldisha avatar Apr 16 '21 20:04 dldisha

Thanks for your work on this @dldisha :) What has been your approach to find out if a script is still having an impact on the site or not?

pitag-ha avatar Apr 21 '21 09:04 pitag-ha

Hi @dldisha. Are you still working on this issue? :)

gurleennsidhuu avatar Apr 28 '21 15:04 gurleennsidhuu

Hello @pitag-ha @patricoferris, I am interested to work on the issue. If anyone is still not working on this issue, can you please assign this to me? Thanks :)

jyotibalodhi avatar May 02 '21 07:05 jyotibalodhi

Hi @jyotibalodhi, we can't guarantee that we could help out with questions and review/merge a PR soon, but if no one else is working on this issue, feel free to work on it! :) @dldisha, @gurleennsidhuu, is anyone of you working on this?

pitag-ha avatar May 03 '21 09:05 pitag-ha

Hi @jyotibalodhi, we can't guarantee that we could help out with questions and review/merge a PR soon, but if no one else is working on this issue, feel free to work on it! :) @dldisha, @gurleennsidhuu, is anyone of you working on this?

Hi. I have not yet started working on this as I was waiting for @dldisha's reply. If she's not working on this, I would like to start working. Thanks. :)

gurleennsidhuu avatar May 03 '21 09:05 gurleennsidhuu

No problem @pitag-ha !! I would love to work on some issues though. :) @gurleennsidhuu sure, you can go ahead, and if you face any issues, I would be happy to help.

jyotibalodhi avatar May 03 '21 10:05 jyotibalodhi

@gurleennsidhuu you might want to check out @dldisha's PR #1538 for some leads on the same issue :)

Srinithyee avatar May 05 '21 10:05 Srinithyee