v2.ocaml.org icon indicating copy to clipboard operation
v2.ocaml.org copied to clipboard

On planet: link to blog itself

Open pitag-ha opened this issue 3 years ago • 5 comments

On the right of the planet page (Home -> Community -> OCaml Planet) we list the blogs that are signed up: Screenshot from 2021-04-15 15-55-24

Clicking on one of them opens the rss (e.g. https://medium.com/feed/ahrefs/tagged/ocaml) rather than the blog itself (e.g. https://tech.ahrefs.com/tagged/ocaml). I suggest adding a link to the blog itself. For example, by adding a link icon next to each blog. Screenshot from 2021-04-15 16-00-40

Why

It's common that you want to check out a blog when you come across it.

How

This issue consists in 2 steps:

  • for eacth blog, add the blog url to the planet metadata. Note that you can usually find the blog url in the link tag of the feed
  • implement the issue ;)

pitag-ha avatar Apr 15 '21 14:04 pitag-ha

@pitag-ha I would like to work on this issue :)

guptadiksha307 avatar Apr 15 '21 15:04 guptadiksha307

@guptadiksha307 , sure, you can go ahead :)

pitag-ha avatar Apr 15 '21 15:04 pitag-ha

@guptadiksha307, let me answer here your question about which file needs to be modified:

I would modify planet_feeds.txt as you've already done, but adding the blog URl instead of replacing the feed URL by it. So at the moment, the first line could look something like:

Andrej Bauer|http://math.andrej.com/feed.xml|http://math.andrej.com/

You will need to find where and how that file is parsed and how the html of the Planet page is generated and modify both according to this issue.

Notice that there's another isssue improving the planet_feeds.txt format. So one of you might need to rebase and adapt to the other one later.

pitag-ha avatar Apr 21 '21 15:04 pitag-ha

Thank you @pitag-ha for the explanation :) It's much clearer now.

guptadiksha307 avatar Apr 21 '21 15:04 guptadiksha307

@pitag-ha kindly review the PR :))

guptadiksha307 avatar Apr 25 '21 10:04 guptadiksha307