v2.ocaml.org icon indicating copy to clipboard operation
v2.ocaml.org copied to clipboard

Published 20 hours ago • verified publisher icon ocaml

improved the site/learn/success.fr.html file translated the whole pag…

Open Lontchi12 opened this issue 3 years ago • 2 comments

…e into french and adjusted what was lacking

Issue Description

Improving the success.fr.html page Quelques succès – OCaml - Google Chrome 4_14_2021 4_12_17 PM

Please include a summary of the issue. The success.fr.html page didnot match with the english version of the page and some sections were not included so i fixed it Fixes # (issue) French translation Content included

Changes Made

Please describe the changes that you made. Quelques succès – OCaml - Google Chrome 4_13_2021 10_00_37 PM Quelques succès – OCaml - Google Chrome 4_13_2021 10_01_01 PM Quelques succès – OCaml - Google Chrome 4_13_2021 10_01_51 PM

  • Please check if the PR fulfills these requirements
  • [x] PR is descriptively titled and links the original issue above
  • [x] Before/after screenshots (if this is a layout change)
  • [x] Details of which platforms the change was tested on (if this is a browser-specific change)
  • [x] Context for what motivated the change (if this is a change to some content)

Lontchi12 avatar Apr 14 '21 16:04 Lontchi12

worked on this issue https://github.com/ocaml/ocaml.org/issues/1413 Your reviews will go a long way to help me improve it Thank you

Lontchi12 avatar Apr 14 '21 17:04 Lontchi12

@patricoferris @Lontchi12, I have already worked on this issue refer to #1454 . Also, I have already given permission to work on this and have raised PR #1509. Sorry Just saw this.

shreyaswikriti avatar Apr 16 '21 20:04 shreyaswikriti