v2.ocaml.org icon indicating copy to clipboard operation
v2.ocaml.org copied to clipboard

Published 20 hours ago • verified publisher icon ocaml

Fixes the footer on cheat_sheets page

Open mahakbansal2019 opened this issue 3 years ago • 8 comments

Issue Description

Because of less content footer was shifted from the bottom of the page. It Fixes the footer on the cheat_sheets page.

Fixes #1361

Changes Made

Replaced the markdown code with HTML in cheat_sheets.md file and styled it with a div by giving a min-height.

Before : Screenshot from 2021-04-07 01-00-05

After : Screenshot from 2021-04-07 01-00-12

  • Please check if the PR fulfills these requirements
  • [x] PR is descriptively titled and links the original issue above
  • [x] Before/after screenshots (if this is a layout change)
  • [x] Details of which platforms the change was tested on (if this is a browser-specific change)
  • [x] Context for what motivated the change (if this is a change to some content)

mahakbansal2019 avatar Apr 07 '21 05:04 mahakbansal2019

I can't seem to see the fix on https://staging.ocaml.org/docs/cheat_sheets.html -- I still have whitespace below the footer.

image

avsm avatar Apr 14 '21 13:04 avsm

@avsm I have checked it on different screen sizes and It looks okay.

Screenshot from 2021-04-14 18-50-27 Screenshot from 2021-04-14 18-50-11 Screenshot from 2021-04-14 18-47-48

mahakbansal2019 avatar Apr 14 '21 13:04 mahakbansal2019

Ah, I see a different problem now too. With Safari, it looks like the margin pushes the footer further down so that scrolling is required.

image

avsm avatar Apr 14 '21 14:04 avsm

@avsm I added a min-height, that's why some scrolling is needed for smaller screens. Also, now when I'm opening this https://staging.ocaml.org/docs/cheat_sheets.html , It is not reflecting the fix as you said. Could you guide me how can I fix this now?

mahakbansal2019 avatar Apr 14 '21 15:04 mahakbansal2019

Am I missing something? I can't see in staging's commit history where these changes were pushed https://github.com/ocaml/ocaml.org/commits/staging?before=0e2d74cd4b029a92582790cf370665d9196bdcce+35&branch=staging?

patricoferris avatar Apr 15 '21 14:04 patricoferris

@patricoferris Initially I was able to see the changes but I can't see them now. @avsm Have you removed those changes from staging?

mahakbansal2019 avatar Apr 15 '21 19:04 mahakbansal2019

@patricoferris Please review this PR @avsm Please guide me on this Thanks

mahakbansal2019 avatar Apr 19 '21 13:04 mahakbansal2019

I did remove the changes from staging, since it's difficult to keep changes that aren't mergeable (since they affect other changes also pushed there). I've just pushed this back to staging.ocaml.org and the behaviour is still there; you should be able reproduce it locally now.

https://user-images.githubusercontent.com/53164/115359961-134f8e00-a1b7-11eb-951a-97dc6ef71c53.mov

avsm avatar Apr 20 '21 08:04 avsm