v2.ocaml.org icon indicating copy to clipboard operation
v2.ocaml.org copied to clipboard

Fix Spacing in Documentation/Papers page

Open Srinithyee opened this issue 3 years ago • 15 comments

@patricoferris @gs0510

I see that there is a lot of space in the left hand side of the page here.

I'd like to fix the spacing from this: image image

to this: after1 after2

If this looks like a good fix, I'd like to start working on it!

Srinithyee avatar Apr 02 '21 13:04 Srinithyee

Thanks a lot for the initiative! I do agree with you that with your approach the page would look a bit nicer, but introducing so many line breaks inside the breadcrumbs seems to make it harder to get an easy from and fast overview than it is now. Do you agree with that?

pitag-ha avatar Apr 06 '21 09:04 pitag-ha

@pitag-ha Yes, I do agree with that. Do you have any other suggestions to implement this? I thought of modifying the span class for the two sections of the page from span4 and span8 to span2 and span10 .Could you please let me know if that works?

Srinithyee avatar Apr 06 '21 10:04 Srinithyee

How would that look like?

pitag-ha avatar Apr 06 '21 13:04 pitag-ha

Like this

after1 after2

Srinithyee avatar Apr 06 '21 13:04 Srinithyee

Isn't that the same screenshot you already put into the issue description? I think it's harder to get an overview over the table of contents there than the way it is now.

pitag-ha avatar Apr 06 '21 14:04 pitag-ha

@Srinithyee I agree with @pitag-ha, I would also like the table of contents to be same as before, but the spacing solution is good. Do you want to provide a screenshot with those, and if it looks good you can go ahead? :)

gs0510 avatar Apr 09 '21 12:04 gs0510

@Srinithyee I agree with @pitag-ha, I would also like the table of contents to be same as before, but the spacing solution is good. Do you want to provide a screenshot with those, and if it looks good you can go ahead? :)

By spacing, I meant the space left on the left hand side of the page, on scrolling down. Like this one below:

image

Is this the spacing you'd like me to propose a solution to fix?

@gs0510 I've already contributed to 3 simple issues [#1441 ,#1440, #1369]. This does look simple to me. Would you suggest me taking this up or leaving it open for the others?

Srinithyee avatar Apr 09 '21 12:04 Srinithyee

@Srinithyee I'd leave it open for someone else to pick up! Thanks!

gs0510 avatar Apr 09 '21 12:04 gs0510

@gs0510 Okay :)

Srinithyee avatar Apr 09 '21 12:04 Srinithyee

@kaniaganda Would you like to work on this as a good-first-issue, incase you haven't found one yet?

Srinithyee avatar Apr 09 '21 12:04 Srinithyee

@Srinithyee Yes! I would like to work on the issue. Thank you!

kaniaganda avatar Apr 10 '21 03:04 kaniaganda

@pitag-ha @gs0510 @Srinithyee Thank you for giving me a chance to work on the issue. After trying to work on it, I don't think I will be able to complete this issue for the time being. If there is anyone else who is interested in fixing the issue, please feel free to work on issue.

kaniaganda avatar Apr 23 '21 07:04 kaniaganda

Hi @kaniaganda shall I work on this?

sanjana-98 avatar Apr 23 '21 07:04 sanjana-98

@sanjana-98 Are you an Outreachy applicant? :) What project are you interested in? Since folks have been contributing for a few weeks, we already have quite a lot of contributions that we are considering for final applications. That being said we would anyway appreciate your contributions and hope you can participate in the next round :) Thanks!

gs0510 avatar Apr 23 '21 10:04 gs0510

@gs0510 I am an outreachy applicant but couldn't contribute initially because of some personal issues. I would feel grateful if you could suggest some issues as am looking to contribute just for my own learning experience

sanjana-98 avatar Apr 29 '21 18:04 sanjana-98