v2.ocaml.org icon indicating copy to clipboard operation
v2.ocaml.org copied to clipboard

Make search icon a button

Open gs0510 opened this issue 3 years ago • 9 comments

Currently the search icon in the header is not clickable, which can be deceiving if you go to click on it. Changing the icon to a button that can be clicked will solve this.

gs0510 avatar Mar 30 '21 15:03 gs0510

Before now, while working on the header I discovered the icon is a background-image that was set to non-repeat, so it's not an icon at all. And putting an icon to the search component would very beneficial, countering the deceptive status.

IkehAkinyemi avatar Mar 30 '21 16:03 IkehAkinyemi

So I propose we remove the background-image and replace it with an actual SVG icon, lightweight and highly compatible with all browsers, including IE. @patricoferris @gs0510

IkehAkinyemi avatar Mar 30 '21 16:03 IkehAkinyemi

@patricoferris @gs0510 Hi! I'm an Outreachy applicant and would like to work on this issue

SanduniK95 avatar Mar 31 '21 12:03 SanduniK95

@SanduniK95 I like @IkehAkinyemi 's idea of replace the background image with an SVG icon and making it clickable. Since @IkehAkinyemi already has worked on a good-first-issue you can do this. Thanks!

gs0510 avatar Mar 31 '21 13:03 gs0510

@SanduniK95 , how is it going? :) Are you still working on this issue?

pitag-ha avatar Apr 09 '21 11:04 pitag-ha

@pitag-ha Yes, I'm working on it! I was having some issues with setting up the project but I'm working on it by referring to the replies of other people who seemed to have had the same problems

SanduniK95 avatar Apr 12 '21 10:04 SanduniK95

@pitag-ha Is this issue still open? If yes, I would like to work on this :)

guptadiksha307 avatar Apr 27 '21 06:04 guptadiksha307

@guptadiksha307, I think it is still open. But notice that each Outreachy applicant can work on maximum one good-first-issue :)

pitag-ha avatar Apr 27 '21 13:04 pitag-ha

@gs0510 can you assign this to me if it's still open?

vishalsingh2972 avatar Apr 29 '23 01:04 vishalsingh2972