opam icon indicating copy to clipboard operation
opam copied to clipboard

Published 20 hours ago • verified publisher icon ocaml

Improve error message when src directory for repo add doesn't exist

Open punchagan opened this issue 2 years ago • 8 comments

Closes #5632

punchagan avatar Sep 29 '23 10:09 punchagan

Thanks for the PR. On the general idea, lgtm! I'll add a test to it, in order to complete it.

rjbou avatar Sep 29 '23 15:09 rjbou

I'll add a test to it, in order to complete it.

There are some existing tests which already fail because of this change. I will go ahead and fix them, to begin with.

punchagan avatar Sep 30 '23 05:09 punchagan

I've added a commit that contains the code review & test update.

rjbou avatar Oct 02 '23 13:10 rjbou

Thanks for the code improvements and the test fixes, @rjbou !

punchagan avatar Oct 03 '23 05:10 punchagan

Thanks for the code improvements and the test fixes, @rjbou !

Let me know if I need to do anything more to finish this PR, @rjbou ! Thanks!

punchagan avatar Nov 23 '23 07:11 punchagan

I've updated the PR, a review from @kit-ty-kate and it's good to merge!

rjbou avatar Nov 23 '23 09:11 rjbou

Sorry for the delay, we are focusing on the release, and there is only me and partly kate working on opam.

rjbou avatar Nov 23 '23 10:11 rjbou

Sorry for the delay, we are focusing on the release, and there is only me and partly kate working on opam.

Thank you for your work on opam!

No worries at all -- I'm not in a hurry to have this merged. I just didn't want to leave it hanging there, and wanted clarity on whether it's waiting on me.

punchagan avatar Nov 23 '23 10:11 punchagan