opam-repository icon indicating copy to clipboard operation
opam-repository copied to clipboard

Lift the restriction on installing 5.3.0+BER on macos+arm64

Open yallop opened this issue 6 months ago • 6 comments

@kayceesrk reports that MetaOCaml 5.3.0+BER can be installed successfully on macos+arm64, so the current constraint is apparently unnecessary.

yallop avatar May 16 '25 13:05 yallop

FWIW the same can be done for 4.14.1+BER:

Thanks. I've made that change in 20f0163

yallop avatar May 16 '25 14:05 yallop

I've pushed two additional commits which will hopefully improve the CI. As it's written at the moment, the 4.14.1 and 5.3.0 packages don't support bytecode-only builds (I'm not sure if MetaOCaml actually supports that itself?), so I added the conflict to the 4.14.1 version as well (that happened to be being caught by CI).

The second commit brings a few of the changes which are in ocaml-compiler.5.3.0 into the BER version - hopefully the 32-bit buillds will be correctly rejected this time.

dra27 avatar May 19 '25 10:05 dra27

The lint error is incorrect (as for compiler packages in general). The failures on Arch I think can be ignored, although there's trouble on the horizon! I think that's GCC 15. For the 4.14.1 version, it's missing ocaml/ocaml#12577 (from 4.14.2). For the 5.3.0 version, I'm wondering if the BER patches have accidentally backed out ocaml/ocaml#12509 and ocaml/ocaml#11764 (which are the "trunk" parts of the 4.14.2 PR), but I haven't looked in detail.

dra27 avatar May 21 '25 10:05 dra27

For the 5.3.0 version, I'm wondering if the BER patches have accidentally backed out ocaml/ocaml#12509 and ocaml/ocaml#11764 (which are the "trunk" parts of the 4.14.2 PR), but I haven't looked in detail.

At a glance, it doesn't look that way: the commit https://github.com/metaocaml/ber-metaocaml/commit/d6b868c (which seems to be the reworking of those PRs in 5.3.0) is on the ber-n153 branch, which is the source for the 5.3.0+BER variant.

yallop avatar May 21 '25 20:05 yallop

No, I’d suggesting ignoring those errors - the existing 4.14.1 is already not working on Arch, so nothing here I think makes it worse. Not sure about constraining it away completely

dra27 avatar Jun 04 '25 14:06 dra27

Is my understanding correct that this should be merged then?

mseri avatar Sep 16 '25 08:09 mseri

I have checked that 5.3.0+BER works on macOS as well!

Zeta611 avatar Sep 17 '25 13:09 Zeta611

Thanks

mseri avatar Sep 17 '25 16:09 mseri