opam-repository icon indicating copy to clipboard operation
opam-repository copied to clipboard

[new release] flint (4 packages) (0.3.3)

Open bobot opened this issue 2 years ago • 11 comments

Stub of the C library Flint2

CHANGES:
  • Fix library name for archlinux: arb instead of flint-arb

bobot avatar Oct 23 '23 11:10 bobot

@Gbury new release with the fix for archlinux. You can add your fix for the conf-* here or later.

bobot avatar Oct 23 '23 11:10 bobot

@bobot I opened a PR in your repository against this branch since I couldn't push to it directly: https://github.com/bobot/opam-repository/pull/1

Gbury avatar Oct 23 '23 15:10 Gbury

Looking at the current CI result, it's essentially doing exactly the same as the last version (i.e. flint.0.3.2)

@Gbury's suggestion might be a valuable addition since the archlinux CI job is failing, and the changelog for this version states adding archlinux support

haochenx avatar Oct 23 '23 17:10 haochenx

Although mergeable as is IMO, it's still nice to consider https://github.com/ocaml/opam-repository/pull/24658#issuecomment-1775419990, so I'll mark this PR as "needs reporter action" for now.

But I want to be clear that there is no pressure to adopt https://github.com/bobot/opam-repository/pull/1 for this PR to be merged in my opionion.

haochenx avatar Oct 23 '23 17:10 haochenx

@Gbury's suggestion might be a valuable addition since the archlinux CI job is failing, and the changelog for this version states adding archlinux support

Note that even with my PR, only flint, arb and antic (and the associated conf-*) packages would likely build on the CI, given that the depext for calcium is in the AUR (see https://github.com/ocaml/opam/issues/5709 for the related issue in opam). However, on a personal machine, it should be easy for users to make it work (by manually installing calcium using one's favorite AUR helper).

Gbury avatar Oct 23 '23 17:10 Gbury

Thanks for the details! Let's see how @bobot reacts. (I can neither modify this PR directly..)

Meanwhile, I will mark this PR as mergeable, as we can always add those depext lines later.

haochenx avatar Oct 23 '23 17:10 haochenx

Thanks! The CI seem to haze succeeded for archlinux

haochenx avatar Oct 24 '23 08:10 haochenx

Actually, wait a bit, the arb and antic packages seem to have disappeared from the archlinux package database overnight...

Gbury avatar Oct 24 '23 09:10 Gbury

Actually, wait a bit, the arb and antic packages seem to have disappeared from the archlinux package database overnight...

https://archlinux.org/packages/extra/x86_64/flint/

It looks like the package is updated on 10/20 and states to replace antic, arb.

This is still a net improvement, so I don't think it's a blocker for this PR.

haochenx avatar Oct 24 '23 12:10 haochenx

Alright, so, this actually does change things quite a bit: flint just released a new major version (version 3) a few days ago, version 3 (and true to its rolling release nature, archlinux packaged it already) and it happens to actually directly integrate arb, antic and calcium, which were previously developed as separate libraries (see https://github.com/flintlib/flint#overview ). In particular this will require another change to the build system for archlinux (since the arb, antic and calcium C library no longer exists, and thus the c flags need to be adjusted), but I hope that it should be reasonable to fix, and I'm working on that.

So in summary, I think we should wait on this PR until I fix that situation because as it stands, the build of the 0.3.3 packages are actually broken on archlinux. The fixes will probably require either a new version 0.3.3 or a 0.3.4 (depending on @bobot 's preference). Luckily, all of this is a result of a rather rare coincidence in terms of releases and packages, and it should help prepare for when other distributions start packaging version 3 of flint.

Gbury avatar Oct 24 '23 13:10 Gbury

I see. In that case, I’m marking this package (at least temporary) as do-not-merge. This PR can be reused or closed in favor of a new one once the necessary changes has been performed upstream.

haochenx avatar Oct 24 '23 18:10 haochenx

What should we do with this PR? Seems that @filipeom fixed a few things on archlinux since then.

samoht avatar Apr 02 '24 11:04 samoht

What should we do with this PR? Seems that @filipeom fixed a few things on archlinux since then.

I closed that PR because I only extended the conf-* to support flint v3 on Arch Linux. However, given that the CI results were failing on other distributions, it's possible that they might already be using flint v3 as well, indicating that the problem may not be isolated to Arch Linux anymore.

@bobot update to flint3 should resolve the Arch Linux issue.

filipeom avatar Apr 02 '24 12:04 filipeom

It seems I played the clock, flint3 will be in ubuntu LTS, which should arrive this month, it is in Arch, it is in fedora Fedora 40. So indeed I will create a new release for it.

bobot avatar Apr 08 '24 07:04 bobot