opam-repository icon indicating copy to clipboard operation
opam-repository copied to clipboard

Package ip2location.8.0.0

Open ip2location opened this issue 1 year ago • 5 comments

ip2location.8.0.0

IP2Location OCaml module to get geolocation data IP2Location IP Geolocation OCaml module enables you to get your visitors' country, region, city, latitude, longitude, ZIP code, ISP, domain name, timezone, connection speed, IDD code, area code, weather station code, weather station name, MCC, MNC, mobile brand name, elevation, usage type, address type and IAB category based on IP address.


  • Homepage: https://github.com/ip2location/ip2location-ocaml
  • Source repo: git+https://github.com/ip2location/ip2location-ocaml.git
  • Bug tracker: https://github.com/ip2location/ip2location-ocaml/issues

:camel: Pull-request generated by opam-publish v2.1.0

ip2location avatar Oct 13 '22 05:10 ip2location

Your dependencies don't seem to to be properly set up. You need to add all the dependencies in your opam file (just like you did here in the dune file).

axrwl avatar Oct 13 '22 07:10 axrwl

Have the sources changed? It is now failing with OpamSolution.Fetch_fail("https://github.com/ip2location/ip2location-ocaml/archive/v8.0.0.tar.gz (Bad checksum, expected md5=6a8674995abf85d0bbbebf9bcb55b920)")

mseri avatar Oct 13 '22 12:10 mseri

I recreated the v8.0.0 release to include the dependencies. That could be why the checksum is not matching. How can I proceed in this case?

ip2location avatar Oct 13 '22 13:10 ip2location

@ip2location simply call opam publish again and it will force-push/update everything automatically in this PR

kit-ty-kate avatar Oct 13 '22 14:10 kit-ty-kate

I have no idea why it keeps failing. Can anyone help me to see what's the problem with the failed jobs?

ip2location avatar Oct 14 '22 08:10 ip2location

The tests are still segfaulting on 32bit architectures

#=== ERROR while compiling ip2location.8.0.0 ==================================#
# context              2.2.0~alpha~dev | linux/x86_32 | ocaml-base-compiler.4.14.0 | pinned(https://github.com/ip2location/ip2location-ocaml/archive/v8.0.0.tar.gz)
# path                 ~/.opam/4.14/.opam-switch/build/ip2location.8.0.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ip2location -j 31 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/ip2location-7-1a9a4b.env
# output-file          ~/.opam/log/ip2location-7-1a9a4b.out
### output ###
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlopt.opt -w -40 -g -o test/ip2locationtest.exe /home/opam/.opam/4.14/lib/stdint/stdint.cmxa -I /home/opam/.opam/4.14/lib/stdint /home/opam/.opam/4.14/lib/macaddr/macaddr.cmxa /home/opam/.opam/4.14/lib/domain-name/domain_name.cmxa /home/opam/.opam/4.14/lib/ipaddr/ipaddr.cmxa /home/opam/.opam/4.14/lib/ocaml/str.cmxa -I /home/opam/.opam/4.14/lib/ocaml -I /home/opam/.opam/4.14/lib/ocaml /home/opam/.opam/4.14/lib/lwt/lwt.cmxa /home/opam/.opam/4.14/lib/re/re.cmxa /home/opam/.opam/4.14/lib/stringext/stringext.cmxa /home/opam/.opam/4.14/lib/bigstringaf/bigstringaf.cmxa -I /home/opam/.opam/4.14/lib/bigstringaf /home/opam/.opam/4.14/lib/angstrom/angstrom.cmxa /home/opam/.opam/4.14/lib/uri/uri.cmxa /home/opam/.opam/4.14/lib/sexplib0/sexplib0.cmxa /home/opam/.opam/4.14/lib/ppx_sexp_conv/runtime-lib/ppx_sexp_conv_lib.cmxa /home/opam/.opam/4.14/lib/uri-sexp/uri_sexp.cmxa /home/opam/.opam/4.14/lib/base64/base64.cmxa /home/opam/.opam/4.14/lib/cohttp/cohttp.cmxa /home/opam/.opam/4.14/lib/fmt/fmt.cmxa /home/opam/.opam/4.14/lib/logs/logs.cmxa /home/opam/.opam/4.14/lib/logs/logs_lwt.cmxa /home/opam/.opam/4.14/lib/ocaml/unix.cmxa -I /home/opam/.opam/4.14/lib/ocaml /home/opam/.opam/4.14/lib/ocaml/bigarray.cmxa -I /home/opam/.opam/4.14/lib/ocaml /home/opam/.opam/4.14/lib/base/caml/caml.cmxa /home/opam/.opam/4.14/lib/parsexp/parsexp.cmxa /home/opam/.opam/4.14/lib/sexplib/sexplib.cmxa /home/opam/.opam/4.14/lib/ipaddr-sexp/ipaddr_sexp.cmxa /home/opam/.opam/4.14/lib/astring/astring.cmxa /home/opam/.opam/4.14/lib/conduit/conduit.cmxa /home/opam/.opam/4.14/lib/conduit-lwt/conduit_lwt.cmxa /home/opam/.opam/4.14/lib/magic-mime/magic_mime_library.cmxa /home/opam/.opam/4.14/lib/ocplib-endian/ocplib_endian.cmxa /home/opam/.opam/4.14/lib/ocplib-endian/bigstring/ocplib_endian_bigstring.cmxa /home/opam/.opam/4.14/lib/ocaml/threads/threads.cmxa -I /home/opam/.opam/4.14/lib/ocaml /home/opam/.opam/4.14/lib/lwt/unix/lwt_unix.cmxa -I /home/opam/.opam/4.14/lib/lwt/unix /home/opam/.opam/4.14/lib/uri/services/uri_services.cmxa /home/opam/.opam/4.14/lib/ipaddr/unix/ipaddr_unix.cmxa /home/opam/.opam/4.14/lib/conduit-lwt-unix/conduit_lwt_unix.cmxa /home/opam/.opam/4.14/lib/cohttp-lwt/cohttp_lwt.cmxa /home/opam/.opam/4.14/lib/logs/logs_fmt.cmxa /home/opam/.opam/4.14/lib/cohttp-lwt-unix/cohttp_lwt_unix.cmxa /home/opam/.opam/4.14/lib/yojson/yojson.cmxa lib/ip2location.cmxa test/.ip2locationtest.eobjs/native/dune__exe__Ip2locationtest.cmx)
# /usr/bin/ld: test/.ip2locationtest.eobjs/native/dune__exe__Ip2locationtest.o: warning: relocation in read-only section `.text'
# /usr/bin/ld: warning: creating DT_TEXTREL in a PIE
# File "test/dune", line 2, characters 7-22:
# 2 |  (name ip2locationtest)
#            ^^^^^^^^^^^^^^^
# (cd _build/default/test && ./ip2locationtest.exe)
# Command got signal SEGV.

Is that expected?

kit-ty-kate avatar Oct 17 '22 14:10 kit-ty-kate

Was testing on 64-bit Debian. Should I need to test on a 32-bit Linux? Or would it be possible to skip the 32-bit tests altogether? If is possible to specify that 32-bit architecture is not compatible, that would be ok too.

ip2location avatar Oct 18 '22 00:10 ip2location

I added a constraint that ip2location is not available on 32-bits architecture (arm32 and x86_32).

dinosaure avatar Oct 20 '22 12:10 dinosaure

@ip2location if you are happy with my last change, I will be happy to merge your PR :+1:.

dinosaure avatar Oct 20 '22 14:10 dinosaure

Thanks. Could you return the fixes in the opam file upstream so that it can be taken into account for next time?

kit-ty-kate avatar Oct 20 '22 14:10 kit-ty-kate

Have updated the opam file upstream. Btw, is there any way to update the dune-project to automatically generate the opam with the 32-bit exclusion?

ip2location avatar Oct 20 '22 23:10 ip2location

not that i know of but you can simply disable the auto-generation. I don't personally think it is useful and does create more issues than it solves.

kit-ty-kate avatar Oct 21 '22 13:10 kit-ty-kate