opam-repository icon indicating copy to clipboard operation
opam-repository copied to clipboard

Published 20 hours ago • verified publisher icon ocaml

Remove conf-libsamplerate in favor of conf-samplerate.

Open toots opened this issue 1 year ago • 2 comments

conf-samplerate and conf-libsamplerate serve the same purpose!

toots avatar Aug 14 '22 22:08 toots

Removing the package outright might break some users. Could you instead do as in https://github.com/ocaml/opam-repository/pull/18145 and create a new conf-libsamplerate.2 package that aliases to conf-samplerate?

Also note that the two packages have different definitions. In particular nixos and alpine (os-family vs. os-distribution) are different. Could you move the relevant changes to conf-samplerate (especially the latter)?

kit-ty-kate avatar Aug 15 '22 13:08 kit-ty-kate

Ping @toots

mseri avatar Oct 13 '22 12:10 mseri

@kit-ty-kate @mseri PR review suggestions applied!

toots avatar Oct 16 '22 16:10 toots

Thanks a lot!

kit-ty-kate avatar Oct 17 '22 10:10 kit-ty-kate