opam-repository icon indicating copy to clipboard operation
opam-repository copied to clipboard

Add new version 3.9 for conf-python-3

Open MSoegtropIMC opened this issue 3 years ago • 12 comments

This PR adds a new version for the python 3 conf package (the latest available is 3.1 which is way too old).

I get btw a lint warning:

warning 62: License doesn't adhere to the SPDX standard, see https://spdx.org/licenses/: "PSF-2.0"

which I would say is a false positive. See (https://spdx.org/licenses/PSF-2.0.html).

Since this package hasn't been updated by the written maintainer, please feel free to put in my Github ID / email.

MSoegtropIMC avatar Mar 29 '22 16:03 MSoegtropIMC

Thanks. I wonder two things:

  1. if we follow conf-python-3-7 from https://github.com/ocaml/opam-repository/pull/20991/files, we can still use this package with ocaml-in-python, so I would suggest to do that.

  2. right now conf-python-3-7 follows conf-python-2-7 and I thought this was the idea also for conf-python-3, by decoupling python version from the conf-python package. This would suggest that this package is called conf-python-3-9. I wonder if it would be better to deprecate everything and instead have conf-python with packages whose version is python's version lower bound. This is going to be imprecise in many cases, but some package managers want the python version specified, so this packages are actually needed from time to time

@kit-ty-kate what do you think?

mseri avatar Mar 29 '22 21:03 mseri

Thanks, I somehow didn't see the con-python-3-7 package. If this is the standard, I will follow it. And yes, I think it might make sense to have a conf-python package which just gives a recent python (if I understood you right, this is what you suggested).

MSoegtropIMC avatar Mar 30 '22 06:03 MSoegtropIMC

Thanks. Please do not modify this for the moment, until we have an agreement with the other maintainers of the opam-repository

mseri avatar Mar 30 '22 06:03 mseri

OK, i will wait for the conclusion. It is not urgent for me since my main projects has its own opam repos, and I keep it there until this is resolved here.

MSoegtropIMC avatar Mar 30 '22 08:03 MSoegtropIMC

We have discussed this with the other maintainers. We are going to create a conf-python package whose versions will follow the targeted python version, so there will be conf-python.3.0, conf-python.3.7 and conf-python.3.9 in there. In such a way that you can depend on >= 3.7 and have more flexibility.

I will take care of doing that in the next few days and will include your changes there

mseri avatar Mar 31 '22 12:03 mseri

@mseri : thanks!

Btw.: I should mention that most distributions do not have a way to select specific versions of python, you can just select python2 or python3. Other distros have separate packages for python 3.x.

This is not really satisfactory, but I don't see a way around it.

MSoegtropIMC avatar Mar 31 '22 13:03 MSoegtropIMC

Yes, I know unfortunately. We do what we can :)

mseri avatar Mar 31 '22 13:03 mseri

We do what we can :)

Which is a lot! I really don't know how I would get my job done without opam.

MSoegtropIMC avatar Mar 31 '22 13:03 MSoegtropIMC

@mseri : some time went by since we last discussed this - as far as I can see there is still no conf-python package. Should I create this?

MSoegtropIMC avatar Aug 12 '22 16:08 MSoegtropIMC

Btw.: the conf-python-3-7 package does not work any more for homebrew - one has to say [email protected]- otherwise opam 2.1.x tries to reinstall it again and again since brew install python@3 installs [email protected] and opam looks for python@3. I guess this came with the switch to new depext.

So it would be a good time to redo the python packages ...

MSoegtropIMC avatar Aug 12 '22 17:08 MSoegtropIMC

Thanks @MSoegtropIMC for pinging me. I could not free enough time for this yet due to some issues at home and then I went in holiday, planning to get back to it this week or the next. If you want to attempt a PR on the line of what I was saying before, I'd be grateful. Otherwise I should be able to do it in a week or so.

Please, do not remove the old packages: we should add a new version to transition to the new conf-python, something like https://github.com/ocaml/opam-repository/pull/18145

mseri avatar Aug 17 '22 08:08 mseri

@mseri : I will adjust my PR to what we discussed (I would include the 3 latest python 3 and the latest python 2 variants (so 4 in total).

I won't remove the old packages but won't add to them either (that is no old style 3.9).

MSoegtropIMC avatar Aug 17 '22 08:08 MSoegtropIMC

We don't have a good solution yet for python packages, so let's merge this as is and sorry for the long wait

mseri avatar Mar 08 '23 14:03 mseri