odoc icon indicating copy to clipboard operation
odoc copied to clipboard

Local ToC renders incorrectly on certain screen sizes when a global ToC isn't present

Open johnridesabike opened this issue 9 months ago • 1 comments

The local table-of-contents doesn't display correctly on a screen size between about 800px and 1600px. The local odoc-tocs class is given grid-area: sidebar but sidebar does not exist in the grid template. This does not seem to happen when a global table-of-contents is present.

The issue, as far as I can tell, is that both of these rules are in effect: https://github.com/ocaml/odoc/blob/42190737339d9be4510eeeb0e3c47e84badf4d73/src/html_support_files/odoc.css#L319 https://github.com/ocaml/odoc/blob/42190737339d9be4510eeeb0e3c47e84badf4d73/src/html_support_files/odoc.css#L1290

I haven't looked into it extensively, but my first guess is that line 319's greater specificity is overriding 1283, which is supposed to be used instead: https://github.com/ocaml/odoc/blob/42190737339d9be4510eeeb0e3c47e84badf4d73/src/html_support_files/odoc.css#L1283

$ odoc --version
3.0.0

Here's an example of what it looks like:

Image

johnridesabike avatar Mar 23 '25 12:03 johnridesabike

Thanks for reporting this, yes, this clearly needs fixing.

jonludlam avatar Mar 24 '25 11:03 jonludlam