ocaml-lsp icon indicating copy to clipboard operation
ocaml-lsp copied to clipboard

Issue with doc on constructors

Open tatchi opened this issue 2 years ago • 4 comments

without params:

https://github.com/ocaml/ocaml-lsp/assets/5595092/502dccda-58ee-45f2-a241-34b548cc12ac

with params:

https://github.com/ocaml/ocaml-lsp/assets/5595092/d3fa12f3-f758-4031-9f0d-0938f57887c3

tatchi avatar Nov 14 '23 10:11 tatchi

This is probably an upstream issue in Merlin. Which version of OCaml / merlin-lib are you using ?

voodoos avatar Nov 14 '23 12:11 voodoos

This is probably an upstream issue in Merlin. Which version of OCaml / merlin-lib are you using ?

ocaml --version
The OCaml toplevel, version 5.0.0
ocamllsp --version
1.16.2
merlin-lib            4.9-500     Merlin's libraries

tatchi avatar Nov 14 '23 12:11 tatchi

@voodoos should we move this issue to Merlin repo?

Also, would creating a test for this be helpful? After a quick look, it seems that adding something to https://github.com/ocaml/merlin/tree/master/tests/test-dirs/document might be the right place?

tatchi avatar Mar 19 '24 13:03 tatchi

@voodoos should we move this issue to Merlin repo?

Also, would creating a test for this be helpful? After a quick look, it seems that adding something to https://github.com/ocaml/merlin/tree/master/tests/test-dirs/document might be the right place?

Actually, there is already a similar test: https://github.com/mheiber/merlin/blob/master/tests/test-dirs/document/issue1513.t Having the issue tracked on Merlin's repository and completing that test or adding a new one would be useful indeed :-)

I expect some of these issues to be fixed when moving to OCaml 5.2 which should allow more precise determination of comments.

voodoos avatar Apr 03 '24 12:04 voodoos