ocaml-lsp icon indicating copy to clipboard operation
ocaml-lsp copied to clipboard

fix(ocamllsp): workspace symbols fallback to _build folder

Open tatchi opened this issue 2 years ago • 2 comments

It checks that the uri exist and otherwise fallback to the _build folder. This might be the case for generated files (that only exist in the _build folder.

Before:

https://github.com/ocaml/ocaml-lsp/assets/5595092/10f65cf6-b048-4058-a0d1-e95ea4c0f136

After:

https://github.com/ocaml/ocaml-lsp/assets/5595092/4e23f045-b25b-400c-91cd-302de3e8e7d1

tatchi avatar May 16 '23 05:05 tatchi

Pull Request Test Coverage Report for Build 3735

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 16.881%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/workspace_symbol.ml 0 5 0.0%
<!-- Total: 0 5
Files with Coverage Reduction New Missed Lines %
ocaml-lsp-server/src/workspace_symbol.ml 1 0.0%
<!-- Total: 1
Totals Coverage Status
Change from base Build 3733: -0.002%
Covered Lines: 3934
Relevant Lines: 23304

💛 - Coveralls

coveralls avatar May 16 '23 05:05 coveralls

Pls add a changelog note

3Rafal avatar May 18 '23 08:05 3Rafal