ocaml-lsp
ocaml-lsp copied to clipboard
fix(ocamllsp): workspace symbols fallback to _build folder
It checks that the uri exist and otherwise fallback to the _build folder. This might be the case for generated files (that only exist in the _build folder.
Before:
https://github.com/ocaml/ocaml-lsp/assets/5595092/10f65cf6-b048-4058-a0d1-e95ea4c0f136
After:
https://github.com/ocaml/ocaml-lsp/assets/5595092/4e23f045-b25b-400c-91cd-302de3e8e7d1
Pull Request Test Coverage Report for Build 3735
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-0.002%) to 16.881%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| ocaml-lsp-server/src/workspace_symbol.ml | 0 | 5 | 0.0% |
| <!-- | Total: | 0 | 5 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| ocaml-lsp-server/src/workspace_symbol.ml | 1 | 0.0% |
| <!-- | Total: | 1 |
| Totals | |
|---|---|
| Change from base Build 3733: | -0.002% |
| Covered Lines: | 3934 |
| Relevant Lines: | 23304 |
💛 - Coveralls
Pls add a changelog note