merlin icon indicating copy to clipboard operation
merlin copied to clipboard

Allow jump to an enclosing module type

Open goldfirere opened this issue 2 years ago • 3 comments

The current jump command allows jumps to an enclosing fun, let, module, or match. It would be great to also add support for module types, perhaps by adding the sig target.

goldfirere avatar Jul 24 '23 16:07 goldfirere

Do you mean jumping to the enclosing sig ... from inside the signature ? Jumping to the module binding seems already quite close to that.

voodoos avatar Jul 25 '23 08:07 voodoos

Yes, exactly. How is jumping to a module binding the same?

goldfirere avatar Jul 25 '23 14:07 goldfirere

There are definitely some cases that could be added to the jump command like sig and struct. It also lacks the module type binding case.

voodoos avatar Jul 25 '23 14:07 voodoos

Hi @goldfirere! PR #1728 implements the behaviour proposed by @voodoos here, is the fix enough or do you really want to jump to sig enclosing specifically?

xvw avatar Mar 15 '24 11:03 xvw

Hello @xvw! Welcome! Yes, that looks like the fix. Thanks.

goldfirere avatar Mar 15 '24 13:03 goldfirere