merlin icon indicating copy to clipboard operation
merlin copied to clipboard

C-c C-l fails for some reason

Open mimoo opened this issue 3 years ago • 7 comments

Hello hello,

I'm getting the following bottom buffer (that looks like it might be an error?) on emacs when trying to jump to definition:

Screenshot 2022-12-21 at 11 06 04 AM

(the offending code)

I've been trying to use emacs since vscode doesn't really work for me (see https://github.com/ocamllabs/vscode-ocaml-platform/issues/1020), but it looks like I'm getting the same kind of jump to definition errors with emacs.

mimoo avatar Dec 21 '22 19:12 mimoo

That is unfortunate indeed. I will try to reproduce on my side.

Meanwhile, could you try to get the complete error log after enabing M-x merlin-enable-debug ? Also a minimal reproduction would be great, but that might be difficult to get.

voodoos avatar Dec 22 '22 08:12 voodoos

I have not been able to reproduce so far: on either vscode of emacs it does jump do the declaration of the value (which is not what we are looking for but still better than the crash you witness).

voodoos avatar Dec 22 '22 08:12 voodoos

do you know what I should do after M-x merlin-enable-debug? I get the same temporary buffer at the bottom when I do that.

mimoo avatar Dec 22 '22 19:12 mimoo

OK I found a *merlin-log* buffer that had the info. Looks like a stack overflow: https://controlc.com/aa924e03

mimoo avatar Dec 22 '22 19:12 mimoo

Thank you. I don't have a file called src/lib/transaction_snark/test/zkapps_examples/thing/thing.ml so I cannot try to reproduce this specific SO.

voodoos avatar Dec 26 '22 09:12 voodoos

Just a blind guess: could you try to explicitely add the mina_wire_types library to the dune file of the concerned lib/executable, then rebuild and retry the query ?

voodoos avatar Dec 26 '22 10:12 voodoos

oh the file is the same as https://github.com/MinaProtocol/mina/blob/develop/src/lib/transaction_snark/test/zkapps_examples/empty_update/empty_update.ml#L31

I tried again today and now it works, not sure what happened in between :|

mimoo avatar Dec 28 '22 19:12 mimoo