merlin icon indicating copy to clipboard operation
merlin copied to clipboard

Emacs Xref improvements

Open mattiase opened this issue 3 years ago • 5 comments

Fix uses of Xref from mouse events, such as the context menu new in Emacs 28, by implementing the necessary methods and smuggle the buffer position in a text property of the string.

We also get better highlighting of Xref hits in the target buffer by taking advantage of a bug fixed in Emacs 28.

mattiase avatar Sep 11 '21 12:09 mattiase

With the last part of this PR, xref can now more easily be used for looking up definitions and occurrences of operators.

mattiase avatar Oct 05 '21 14:10 mattiase

@rgrinberg I requested your review since you appear to be the author of the initial xref support.

voodoos avatar Mar 28 '22 13:03 voodoos

I don't use any Emacs anymore and don't remember much of elisp. I think we need to find someone else to review unfortunately.

rgrinberg avatar Mar 28 '22 19:03 rgrinberg

Tell me if there is anything more I should do with the patch set. I did consult the author of the Xref facility in Emacs for how best to use the interface in a way that's compatible with different versions.

mattiase avatar Apr 06 '22 13:04 mattiase

The changes look good to me.

bbatsov avatar Jun 21 '22 08:06 bbatsov

Not sure what this patch is waiting for – all rather straightforward things I thought. Anyway, it's up to date with master.

mattiase avatar Dec 22 '22 11:12 mattiase

@rgrinberg Can you help us to get this merged?

bbatsov avatar Dec 22 '22 11:12 bbatsov

Thanks for your review @bbatsov, and @mattiase for rebasing the PR. Sorry it took so long.

@mattiase could you add a changelog entry for this one ? Thank you !

voodoos avatar Dec 22 '22 11:12 voodoos

@mattiase could you add a changelog entry for this one ?

Done.

mattiase avatar Dec 22 '22 12:12 mattiase