dune icon indicating copy to clipboard operation
dune copied to clipboard

feature: enable directory targets for everyone

Open rgrinberg opened this issue 1 year ago • 3 comments

The [(using directory-targets 0.1)] extension has been removed and starting from 3.13, directory targets are fully supported.

Signed-off-by: Rudi Grinberg [email protected]

rgrinberg avatar Jan 11 '24 00:01 rgrinberg

Actually, I wonder if we should wait a bit. We are doing some implementation/semantic clean up internally (cc @rleshchinskiy) and might change the behaviour in some edge cases. It would be best to upstream those changes while this feature still has an experimental status.

Specifically, we'd like to do the following:

  • Forbid requesting subdirectories of a directory target from command line (the current implementation has some weird behaviour in those cases). This allows simplifying build_system.ml quite a bit.

  • Make it possible to declare dependencies on whole directory targets (instead of having to use globs). This seems like an important feature to have to make directory targets first class.

snowleopard avatar Jan 11 '24 10:01 snowleopard

Yes, waiting sounds good. We can always check back for 3.14. This will avoid supporting the old version forever when the semantics change.

emillon avatar Jan 11 '24 13:01 emillon

Holding off sounds fine to me

Make it possible to declare dependencies on whole directory targets (instead of having to use globs). This seems like an important feature to have to make directory targets first class.

Isn't this already possible?

rgrinberg avatar Jan 11 '24 21:01 rgrinberg