dune icon indicating copy to clipboard operation
dune copied to clipboard

fix(oxcaml): js_of_ocaml compile whole for parameterised instances

Open art-w opened this issue 3 months ago • 1 comments

Fixes #12564

Follow up on #12561 : Js_of_ocaml and wasm_of_ocaml don't currently support the incremental compilation of OxCaml parameterised libraries instantiation, so we have to enforce whole program compilation.

art-w avatar Nov 21 '25 11:11 art-w

I don't really understand the direction taken by this PR. The change proposed here is not discover-able, hard to explain. The user might not even be aware that there are parameterised instances in the cone of dependencies. I think, time would be better spent fixing the actual issue. I had a quick look and the issue might be because of https://github.com/ocsigen/js_of_ocaml/pull/2105#discussion_r2597995219.

hhugo avatar Dec 10 '25 21:12 hhugo

I've pushed a quick fix in the oxcaml branch in jsoo repo. I believe that what's missing now is a proper setup in dune itself

hhugo avatar Dec 15 '25 14:12 hhugo

Thanks @hhugo ! I'll update the PR to enable separate compilation, the whole compilation restriction was only intended as a temporary fix to avoid crashing :)

art-w avatar Dec 15 '25 16:12 art-w