dune
dune copied to clipboard
feat: introduce env_vars alias for env-vars
This PR introduces an alias env_vars, for env-vars, to keep the configuration uniformity (using the underscore instead of dash).
Closes #11424
I agree! But is it a good idea to introduce it as a breaking change for 3.18 and not for 4.0?
@nojb what do you think about allowing both but emit a warning for now with env-vars, and removing it for 4.0.0?
I don't particularly care if we have more than one name, but I'm strongly against making breaking changes that offer no benefits to the user. So even if we introduce a new name, we need to keep supporting the old name even in 4.0. We need much more convincing reasons to break user builds.
I don't particularly care if we have more than one name, but I'm strongly against making breaking changes that offer no benefits to the user. So even if we introduce a new name, we need to keep supporting the old name even in 4.0. We need much more convincing reasons to break user builds.
OK!
OK, so let's stick to the two names, then.