dune icon indicating copy to clipboard operation
dune copied to clipboard

feat: introduce env_vars alias for env-vars

Open maiste opened this issue 10 months ago • 5 comments

This PR introduces an alias env_vars, for env-vars, to keep the configuration uniformity (using the underscore instead of dash).

Closes #11424

maiste avatar Feb 04 '25 11:02 maiste

I agree! But is it a good idea to introduce it as a breaking change for 3.18 and not for 4.0?

maiste avatar Feb 05 '25 10:02 maiste

@nojb what do you think about allowing both but emit a warning for now with env-vars, and removing it for 4.0.0?

maiste avatar Feb 06 '25 09:02 maiste

I don't particularly care if we have more than one name, but I'm strongly against making breaking changes that offer no benefits to the user. So even if we introduce a new name, we need to keep supporting the old name even in 4.0. We need much more convincing reasons to break user builds.

rgrinberg avatar Feb 06 '25 10:02 rgrinberg

I don't particularly care if we have more than one name, but I'm strongly against making breaking changes that offer no benefits to the user. So even if we introduce a new name, we need to keep supporting the old name even in 4.0. We need much more convincing reasons to break user builds.

OK!

nojb avatar Feb 06 '25 11:02 nojb

OK, so let's stick to the two names, then.

maiste avatar Feb 06 '25 12:02 maiste