dune Configurator: pkg-config plugin uses pkgconf and --personality=TARGET by default

This change is required to support windows mingw opam.2.2 default setting. It can be seen as a "clean" attempt to do https://github.com/dra27/dune/commit/fd003a00e5acb213236ba04d8d3000beda552ca8 :-)

Maybe review commit by commit as commit messages tries to provide explanations.

Obviously the last one (refreshing test outputs) is not satisfactory as it but as I don't know what is the best fix, I open the PR now as an ask for feedback...

Sep 19 '24 13:09 pirbo

Could you add a changelog entry and potentially some documentation of the behavior so people are aware of it?

Oct 17 '24 18:10 Leonidas-from-XIV

Making the tests pass would be appreciated as well

Oct 18 '24 09:10 rgrinberg

Documentation updated (and of course not promoting the next test output was a glitch...) Edit: Sorry, I forgot to thank you for your reviews... :-) Thank you!

Oct 18 '24 11:10 pirbo

I've pushed a fixup commit (that I'll of course squash if it works) to try blindly to please MacOS sed... If not, I'll only have an hand on a mac to try on my side tonight...

Oct 18 '24 14:10 pirbo

@anmonteiro could we test this one on nix?

Oct 18 '24 15:10 rgrinberg

@anmonteiro could we test this one on nix?

Naively this looks good to me but I still need to properly test it. Please allow a couple days for me to take this for a spin.

Oct 20 '24 21:10 anmonteiro

kicked off a test run here: https://github.com/nix-ocaml/nix-overlays/pull/1717

we build a few packages that rely on pkg-config, also for x-compilation.

Oct 20 '24 21:10 anmonteiro