learn-ocaml icon indicating copy to clipboard operation
learn-ocaml copied to clipboard

bug: two implementation details are fragile in partition-view

Open Plictox opened this issue 2 years ago • 1 comments

  • Kind: bugfix
  • Close #456

Description

Checklist

Note to maintainers

  • Read this wiki page.
  • Make sure the PR has a milestone.
  • Assign yourself before merging.
  • [ ] Either do a regular merge:
    • for PRs containing several commits following conventional-commits,
    • or for PRs containing 1 commit shared with a later PR (to preserve the SHA1)
  • [ ] Or do a squash-merge:
    • for PRs containing only 1 commit (not shared with a later PR),
    • or for PRs containing several commits that need not be kept in the history;
    • Update the commit message header with a conventional-commit type,
    • Add a footer Close #… if a related issue exists.

Plictox avatar May 05 '23 09:05 Plictox

Thanks @Plictox!

Note BTW: the standard convention for assignees in GitHub public repositories is generally as follows:

→ The developer that implements the feature (you) is the assignee of the issue (#456)

→ The maintainer that reviews the contribution (me) is the assignee of the PR (#550) : updating this now.

Have a nice WE and see you.

erikmd avatar May 05 '23 20:05 erikmd