reagents icon indicating copy to clipboard operation
reagents copied to clipboard

New release to include jbuilder to dune port?

Open edwintorok opened this issue 3 years ago • 2 comments

With OCaml 4.12.0+domains+effects I get this compile error when installing the package using the multicore opam repo:

#=== ERROR while compiling reagents.0.3.0 =====================================#
# context     2.1.1 | linux/x86_64 | ocaml-variants.4.12.0+domains+effects | git+https://github.com/ocaml-multicore/multicore-opam.git
# path        /var/tmp/edwin-caches/.opam/4.12.0+domains+effects/.opam-switch/build/reagents.0.3.0
# command     /var/tmp/edwin-caches/.opam/opam-init/hooks/sandbox.sh build jbuilder build -p reagents -j 8
# exit-code   1
# env-file    /var/tmp/edwin-caches/.opam/log/reagents-111832-3feaf4.env
# output-file /var/tmp/edwin-caches/.opam/log/reagents-111832-3feaf4.out
### output ###
# bwrap: execvp jbuilder: No such file or directory

Easily fixed by opam install jbuilder, but either the package should be updated to have a dependency on it, or it should be upgraded to use dune.

(and then the next build error is solved by pinning kcas https://github.com/ocaml-multicore/kcas/issues/10).

I see that master already uses dune, so I think this only needs a new release (or updating the opam file on the current one to add jbuilder as dependency).

edwintorok avatar Dec 22 '21 00:12 edwintorok

Thanks for the bug report. kcas and reagents are not actively maintained now as the multicore team does not have the resources to do so. We will have to come back to this after the 5.00 release.

kayceesrk avatar Dec 22 '21 06:12 kayceesrk

There is a new release of kcas 0.1.5 on opam @edwintorok . Reagents is being worked but not ready for an opam release. The latest change https://github.com/ocaml-multicore/reagents/commit/b02fd03b5964d1dd6e3cbc43322c7d17d10b941b will build with dune but has issues with the examples provided, see https://github.com/ocaml-multicore/reagents/pull/28 for more details.

tmcgilchrist avatar Dec 13 '22 00:12 tmcgilchrist