meta icon indicating copy to clipboard operation
meta copied to clipboard

Request to move ocamlscript to ocaml-community

Open mjambon opened this issue 4 years ago • 13 comments

Francois Berenger (@UnixJunkie), a long-time member of the ocaml open-source community would like to take over the ocamlscript project. I think ocaml-community is a fitting home for the project.

Project name: ocamlscript

Initial author(s): David Mentré, Martin Jambon

Current URL: https://github.com/mjambon/ocamlscript

License: Boost software license

Description: compiles ocaml scripts starting with #! /usr/bin/env ocamlscript just in time with ocamlopt and runs them. Supports libraries specified as ocamlfind packages, and multiple source files.

Do the current maintainer(s) agree with the move: yes

New maintainer: Francois Berenger (@UnixJunkie)

mjambon avatar Feb 05 '21 03:02 mjambon

I agree.

UnixJunkie avatar Feb 05 '21 03:02 UnixJunkie

Seems fine by me. If you request a transfer, I'll set him up as the maintainer.

pmetzger avatar Mar 01 '21 13:03 pmetzger

I just made the transfer request.

mjambon avatar Mar 01 '21 20:03 mjambon

I can't find the request email anywhere...

pmetzger avatar Mar 02 '21 01:03 pmetzger

Looks like it's been transferred successfully! Thank you!

https://github.com/mjambon/ocamlscript now redirects to https://github.com/ocaml-community/ocamlscript

mjambon avatar Mar 02 '21 03:03 mjambon

Okay, then @UnixJunkie should now follow the steps to "standardize" the repository per usual ocaml-community guidelines. After that we can close this.

pmetzger avatar Mar 03 '21 01:03 pmetzger

@pmetzger and where are those guidelines published?

UnixJunkie avatar Mar 03 '21 02:03 UnixJunkie

They're in https://github.com/ocaml-community/meta/blob/master/README.md

pmetzger avatar Mar 03 '21 02:03 pmetzger

@pmetzger I am sorry, but I did not sign for all this:

A few changes should be made to the code as soon as possible following repository migration, not necessarily in this order:

    A .travis.yml file should be added to the repository and the CI system should be turned on by an administrator. Generally, builds should be tried on the latest several versions of OCaml, on both Linux and on MacOS.

If you contribute a working template, this might be done. Clearly not my priority.

The new code owners should be placed into a CODEOWNERS file in the repository.

This can be done.

The repository should be carefully checked for references to old repository locations, home pages, maintainers, etc., and these references should be updated.

This can be done.

The code should be updated so that it compiles and runs on the latest version of OCaml.

Already the case.

An OPAM package should be created and submitted for the package if one does not yet exist, or the existing package should be updated to point to the new repository location.

Already done.

If feasible, older build systems should be converted to dune.

This is underway but there is a problem; help welcome:

https://github.com/ocaml-community/ocamlscript/issues/7

UnixJunkie avatar Mar 03 '21 02:03 UnixJunkie

I am sorry, but I did not sign for all this:

"All of that" (except for the dune conversion) is ten minutes of work, and is important. For example, we need a CI to assure code quality of submitted merge requests with minimum fuss (and the necessary travis file is easy to find in any other ocaml-community respository.) Please do go through the list; most of the items are trivial and all of them are quick except for the dune conversion.

pmetzger avatar Mar 03 '21 14:03 pmetzger

I think the travis bit is outdated, it should be github actions these days :-)

c-cube avatar Mar 03 '21 16:03 c-cube

I've used both GitHub Actions and CircleCI, and I vastly prefer the latter. Their documentation is good™.

This is the CircleCI setup used by dune-deps (simple project that produces one executable): https://github.com/mjambon/dune-deps/blob/master/.circleci/config.yml The docker image is derived from ocaml-layer but if you don't want to bother with this, I recommend using one of these: https://hub.docker.com/r/ocaml/opam2/tags

mjambon avatar Mar 03 '21 23:03 mjambon

@c-cube Work/Patches to move to Github Actions cheerfully accepted; I doubt I have time to do it right now but it would be a Very Very Big Help. See also: https://github.com/ocaml-community/meta/issues/30

pmetzger avatar Mar 04 '21 20:03 pmetzger