rapid-router icon indicating copy to clipboard operation
rapid-router copied to clipboard

Save user's preferred language across Rapid Router levels

Open evemartin opened this issue 1 year ago • 3 comments

At the moment, whenever you leave a level and select a new one, the language dropdown resets (to your browser's default language) even if you have changed it in the level. It would be good if Rapid Router saved the user's preferred language across levels instead of resetting it every time.

One possible direction to look in for this ticket is cookies, similar to what we did with the Rapid Router mute cookie a little while ago.

evemartin avatar May 13 '24 14:05 evemartin

Hey team! Please add your planning poker estimate with Zenhub @evemartin @faucomte97 @SKairinos

lauracumming avatar Jun 27 '24 11:06 lauracumming

Update before I go on holiday: tested on dev and ready for review!

evemartin avatar Jul 01 '24 16:07 evemartin

Reviewing - checking something with the legal team re cookie consent behaviour.

faucomte97 avatar Jul 02 '24 12:07 faucomte97

Ready for review on staging. Please test that the cookies not only work when consent to functional cookies, but also that the cookies get deleted when withdrawing consent after the cookies have been activated. You can check that in the Application tab of the browser DevTools when looking at the cookie list. The muted and preferredLanguage cookies should both disappear (only when going back to a Rapid Router level, not before).

faucomte97 avatar Jul 12 '24 13:07 faucomte97

LGTM - I followed the above comment

SKairinos avatar Jul 19 '24 10:07 SKairinos

LGTM - Also noted the above

lauracumming avatar Jul 19 '24 13:07 lauracumming

LGTM

lauracumming avatar Jul 25 '24 13:07 lauracumming

LGTM

SalmanAsh avatar Jul 29 '24 14:07 SalmanAsh