codeforlife-portal icon indicating copy to clipboard operation
codeforlife-portal copied to clipboard

Add gmail/outlook buttons to reset password page

Open lauracumming opened this issue 9 months ago • 2 comments

Task Description

image.png

Acceptance Criteria

  • [ ] ...
  • [ ] ...

Analytics Requirements

  • [ ] ...

Copywrite Requirements

  • [ ] ...

lauracumming avatar May 03 '24 13:05 lauracumming

accidentally committed straight to master. why was this possible? Please review and if there are change requests, I will revert the commit and make it a legit PR https://github.com/ocadotechnology/codeforlife-portal/commit/8ae60b9be21f9a851f99a602ea3a58b5f4a1a3ab

SKairinos avatar May 13 '24 14:05 SKairinos

The buttons look good to me!

evemartin avatar May 14 '24 12:05 evemartin

  • [x] Check Cookie banner: banner loads, categories in the right order, cookies disabled by default
  • [x] Check Rapid Router: game loads, can solve a level, can save a workspace, can create a level, can save a level, scores get saved, scoreboard loads
  • [x] Check OS on browserstack
  • [x] Approved on production

lauracumming avatar May 21 '24 07:05 lauracumming

Does this work for anyone on production? Please check

lauracumming avatar May 21 '24 07:05 lauracumming

It also doesn't work for me - I think it's because we changed the Dotdigital domain after this was deployed, so the gmail button is still searching for emails sent from the old domain :( I think Florian added it as a bug for the last sprint in the sprint checklist spreadsheet!

evemartin avatar May 21 '24 08:05 evemartin

Okay. I'll add this into this sprint, as i thought it was just that it wasn't searching correctly but it still opened the right application.

lauracumming avatar May 21 '24 08:05 lauracumming

Sounds good - although it does still open the right application for me, it just searches wrong. What happens for you?

evemartin avatar May 21 '24 08:05 evemartin

Task added to this sprint https://app.zenhub.com/workspaces/code-for-life-sprint-board-5dc58d4a85c6bd00010b8148/issues/gh/ocadotechnology/codeforlife-portal/2306

lauracumming avatar May 21 '24 08:05 lauracumming