sahi icon indicating copy to clipboard operation
sahi copied to clipboard

Language-based object detectors (GLIP, Grounding DINO) support for MMDetection

Open AMauri996 opened this issue 1 year ago • 10 comments

Hello ! I've added support of language-based object detectors (GLIP, Grounding DINO) from the latest release of MMdetection which require a text prompt in order to work. I've also included a test and download utils.

Users can provide a custom text prompt using --text argument. If none is provided the class names are used as the text prompt.

AMauri996 avatar Mar 08 '24 08:03 AMauri996

Amazing PR @AMauri996 ! 🔥 🚀

Can you also include a quickstart notebook as in other integrations so that users know how to use it?

You can take a look at other notebook files here: https://github.com/obss/sahi/tree/main/demo

fcakyon avatar Apr 08 '24 15:04 fcakyon

Hello @fcakyon ! Thank you for your review. I've added the demo for GLIP here.

AMauri996 avatar Apr 09 '24 12:04 AMauri996

@AMauri996 can you fix the styling?

fcakyon avatar Apr 22 '24 18:04 fcakyon

Is there something missing? Happy to jump and help in case it is needed

RobertoPalomares avatar May 16 '24 10:05 RobertoPalomares

@fcakyon I fixed the styling, it should be good now

AMauri996 avatar May 17 '24 07:05 AMauri996

@AMauri996 thanks a lot!

Please fix the nltk based failure in the continuous integration tests @AMauri996 @RobertoPalomares 👍🏻

https://github.com/obss/sahi/pull/1003/checks

fcakyon avatar May 18 '24 15:05 fcakyon

@fcakyon I fixed the nltk error in the tests

AMauri996 avatar May 27 '24 13:05 AMauri996

Thanks for the fast fix, @AMauri996. Can you please update demo notebook using the latest up-to-date mmdetection notebook available in the sahi repo? Then we would be glad to merge your contribution!

fcakyon avatar Jun 02 '24 21:06 fcakyon

Hello @fcakyon ! I've solved the merge conflict caused by the mmdetection notebook

AMauri996 avatar Jul 19 '24 10:07 AMauri996

Hello @fcakyon ! I've solved the merge conflict caused by the mmdetection notebook

Thanks for your efforts @AMauri996 !

Why do you think the mmdet tests are failing? 🤔 https://github.com/obss/sahi/actions/runs/10006492987/job/28194626143?pr=1003#step:19:1340

fcakyon avatar Aug 05 '24 18:08 fcakyon