obspy
obspy copied to clipboard
obspy
Replace our SEG-Y/SU reader with segyio
We have a ton of open SEG-Y/SU issues (https://github.com/obspy/obspy/labels/.io.segy) and none of the core developers is really an expert in the format. Additionally it is mostly used in active source seismics which is also not our core competency. I propose to replace our current implementation with a thin wrapper around segyio (https://github.com/equinor/segyio).
The reason for the wrapper would be two-fold:
(1) Not break existing codes. We can somewhat assure this by making sure our test suite still runs. (2) A simple bridge from ObsPy <-> segyio
The license is compatible and feature wise I think it should be able to replace our internal implementation. The major issue I see is distribution - we'd probably have to build packages for the various ways we distribute ObsPy (conda, debian, fedora, ...) and additionally make the same compatibility guarantees we currently have. I'm not sure how much work this would be.
For the last reason I propose to implement this after 1.2.0 at the same time we drop Python 2 support.
Any questions/comments?
CC @jokva To make you aware of this any and maybe you also have some comments.
Lion, what about this https://github.com/sixty-north/segpy ? rabbit
Segpy has alternate terms for commercial use. From their readme,
Alternative commercial license terms are available from Sixty North AS if you wish to redistribute Segpy as part of a proprietary closed source product or deliver software software-as-a-service (SaaS) using Segpy as part of a proprietary closed source service.
This could lead to commercial users accidentally going against Sixty North's wishes if they assume that all modules of obspy are available under the same terms.
Yea I agree. It does not seem a viable alternative. The AGPL is also a bit too much for us to be honest.
Licence seems compatible, at least, segyio's LGPL.
distribute ObsPy (conda, debian, fedora, ...)
Well, segyio's already in debian, so we're covered there. I'd love to get some packaging up for fedora too, so maybe it's about time we actually do that. Conda shouldn't be too much of a problem I hope, there's an open issue on it in our tracker too.
