obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

rtmp-services: Add LiveStreamerCafe

Open Tophicles opened this issue 2 years ago • 5 comments

Description

Add Live Streamer Cafe as an RTMP service

Motivation and Context

Ease of use for our streamers to have built in support

How Has This Been Tested?

Tested local build successfully

Types of changes

Tweak

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

Tophicles avatar Feb 03 '23 15:02 Tophicles

Please use the present tense "Add" in the commit message subject, per our Commit Guidelines.

Apologies - totally a newb to the GIT scene. I think I changed it properly now :)

Tophicles avatar Feb 03 '23 16:02 Tophicles

You changed the PR title, but not the commit message.

RytoEX avatar Feb 03 '23 16:02 RytoEX

Also, apologies for missing in the first review, but please also increment the version number in package.json, per our Service Submission Guidelines.

Oh man, changed. I'm sure you're screen capturing this and laughing! Haha. So sorry for the confusion.

Tophicles avatar Feb 03 '23 16:02 Tophicles

Also, apologies for missing in the first review, but please also increment the version number in package.json, per our Service Submission Guidelines.

Oh man, changed. I'm sure you're screen capturing this and laughing! Haha. So sorry for the confusion.

Not at all. My goal is simply to get the PR into a mergeable state.

RytoEX avatar Feb 03 '23 16:02 RytoEX

Also, apologies for missing in the first review, but please also increment the version number in package.json, per our Service Submission Guidelines.

Oh man, changed. I'm sure you're screen capturing this and laughing! Haha. So sorry for the confusion.

Not at all. My goal is simply to get the PR into a mergeable state.

I totally get it... I was kidding. Thanks for your patience :) I hope we're good now!

Tophicles avatar Feb 03 '23 16:02 Tophicles