obsproject
obs-filter: Revert code for expander
Description
Some code was applied to both expander and upward compressor. We limit it now to the compressor to keep the same behaviour as previous versions. The said code was setting the gain to 0 dB above threshold. Fixes issue #8030 .
Motivation and Context
Try not to break existing behaviour. Some users report clicks : https://github.com/obsproject/obs-studio/issues/8030
How Has This Been Tested?
Works as v28.
Types of changes
- Bug fix (non-breaking change which fixes an issue)
Checklist:
- [x] My code has been run through clang-format.
- [x] I have read the contributing document.
- [x] My code is not on the master branch.
- [x] The code has been tested.
- [x] All commit messages are properly formatted and commits squashed where appropriate.
- [x] I have included updates to all appropriate documentation.
Was the original commit not cleanly revertable? The commit message initially struck me as "removing expander filter", so I'm trying to understand the scope of this change and the original commit to see if this commit message can be clarified.
Mmh the wording is probably unclear. The previous commit applied a change to both expander and downward compressor since they share code. The current commit makes the change only for the compressor. I'll try to find some other wording.
Is there a way to just "download" a build with this fix? I can test it. But I am not in position to build it right now, unfortunately.
I see in logs: obs-studio-macos-arm64-6707864a0 but no idea how to access it.
upd: found it here https://github.com/obsproject/obs-studio/actions/runs/3887608341
Yes, this seems to fix it.
v29-this-build https://user-images.githubusercontent.com/1080269/212062471-4411eef6-1092-4026-8a27-e98e9dc924be.mp4
v28.1.2 https://user-images.githubusercontent.com/1080269/212062487-f5b7c449-7d55-454a-a711-86d646902c3b.mp4
Thanks! Not sure if it breaks something though.