obs-studio
obs-studio copied to clipboard
obsproject
cmake: Forward extra args in obs_status to message
Description
Forwards extra arguments given to obs_status to message who will then concatenate them together.
Motivation and Context
So far, I see this only making a difference in exactly one place: https://github.com/obsproject/obs-studio/blob/510f0116a62c12ea6c3812bb88a672ebbebef6a6/cmake/Modules/CompilerConfig.cmake#L48-L51
The "Please download the most recent Windows 10 SDK in order to compile." line is missing from the output since it's a third argument.
Alternatively, I could just fix that one place. I have no preference.
How Has This Been Tested?
I've run CMake in way that would trigger that message so it displays the correct text. It gives the output:
CMake Error at cmake/Modules/ObsHelpers.cmake:446 (message):
OBS: OBS requires Windows 10 SDK version 10.0.20348.0 and above to compile.
Please download the most recent Windows 10 SDK in order to compile.
which appears to be correct.
Other messages haven't changed at all.
Types of changes
- Tweak (non-breaking change to improve existing functionality)
Checklist:
- [x] My code has been run through clang-format.
- [x] I have read the contributing document.
- [x] My code is not on the master branch.
- [x] The code has been tested.
- [x] All commit messages are properly formatted and commits squashed where appropriate.
- [x] I have included updates to all appropriate documentation.
The observation is correct, seems to me like a better fix would remove the text parameter and use ARGN entirely though.
The observation is correct, seems to me like a better fix would remove the
textparameter and useARGNentirely though.
Circling back around to this item. Let's do this, barring any major issues.
Probably not required as that call was used in legacy CMake only and we’re gonna move Linux off that soon as well.
@PatTheMav Do we still want this?
IMO the legacy build path is in "maintenance mode" now, so we accept bugfixes but no new features.