obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

PipeWire buffer transform

Open columbarius opened this issue 3 years ago • 5 comments

Description

Import PipeWire buffers respecting previously applied transformations.

Motivation and Context

The wlroots Portal implementation won't transform buffers and as such a screencast is displayed wrongly if the output is rotated. This MR aims to prototype PipeWire buffer transformation informations to read the screencontent correctly from the rotated buffer.

How Has This Been Tested?

No test available yet.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

columbarius avatar Nov 11 '22 22:11 columbarius

I understand that this is a draft, but please make sure that you fully fill out the template. If the template isn't ready to be filled out, than the PR isn't ready for submission, even as a draft.

Fenrirthviti avatar Nov 11 '22 22:11 Fenrirthviti

I guess I should again squash the guard commit?

columbarius avatar Dec 09 '22 21:12 columbarius

May this receive the 'Seeking testers' label, please? This should allow wlroots users to stream their screen correctly when the screen is rotated.

columbarius avatar Dec 25 '22 01:12 columbarius

Can confirm the flatpak build works with xdpw master and sway. Ready for review.

CC: @GeorgesStavracas @kkartaltepe

columbarius avatar Dec 28 '22 23:12 columbarius

Build a flatpak version of this MR without bumping the PipeWire version and it works as expected without doing any rotation.

columbarius avatar Dec 29 '22 02:12 columbarius

rebased and conflicts resolved.

columbarius avatar Feb 20 '23 14:02 columbarius

Thanks for merging!

columbarius avatar Feb 25 '23 21:02 columbarius