obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

libobs: Move async filtering from render to tick

Open jpark37 opened this issue 2 years ago • 1 comments

Description

Fixes frame/texture size mismatch crash that can happen at render time.

Fixes #5831 Fixes #6188

Motivation and Context

Don't want OBS to crash.

How Has This Been Tested?

Verified async render delay on regular sources, and yadif-deinterlaced sources. No leaks.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

jpark37 avatar Aug 19 '22 04:08 jpark37

wow, it's really efficient to fix this issue and seems to work fine.

tuduweb avatar Aug 19 '22 08:08 tuduweb

Just curious, is there anything stopping this PR from being merged, at this point? And/or is there further testingthat needs to be done that I could potentially assist with? Would be happy to do what I can (if anything) to get this merged for the benefits it offers to #6692 (though I also admit I'm unclear why this doesn't fix that problem completely, but that's neither here nor there)

alinsavix avatar Nov 02 '22 22:11 alinsavix