obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

UI: Add hotkey for resize output (source size)

Open cg2121 opened this issue 2 years ago • 5 comments

Description

Adds hotkey for resizing the output based on current source size.

Motivation and Context

https://github.com/obsproject/obs-studio/commit/829e906ac2b15d822173009cde5c90b5ec6c04c1 removed the feature all together, this just removes it from the context menu and changes it to a hotkey

How Has This Been Tested?

Resized output with the hotkey.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

cg2121 avatar Jul 27 '22 19:07 cg2121

I don't understand why this was removed in the first place, and hotkey discoverability kinda sucks, but it's better than nothing.

derrod avatar Jul 27 '22 19:07 derrod

A hotkey feels like a really odd place to put this option as it's unlikely to be used multiple times. Perhaps the option could be a pop-up dialog on the Video page in settings ("Pick a source to set the canvas size to")? There's plenty of free space in the UI there for more esoteric options like this.

notr1ch avatar Jul 27 '22 19:07 notr1ch

I agree with R1ch, it was removed from the right-click menu since it wasn't something you'd use regularly (or even just semi-regularly). In that sense, a hotkey might be worse than where it was before.

@derrod it was removed since it didn't really fit in the right-click menu, which is supposed to be for actions you'd use semi-regularly, and there wasn't an obvious place in the program where it would fit better. Additionally, it's used for a workflow that OBS in general isn't really made for or good at (dynamic-ish output size), and one of the bigger reasons for it being in Studio was just that it also was in Classic (at least so I was told).

For more context, a comment on the PR where the menu was removed:

"However I will say: I think from a design standpoint, it's providing functionality OBS theoretically isn't built for currently and shouldn't be there. We're accelerating a workflow we don't do a very good job of supporting.

If a user wants to regularly record individual windows or games that vary in dimensions, I think they're better off with a program like ShareX until such a time we can provide a proper and convenient workflow for it."

Because of the reasons above, I'm not sure if it's a good idea to reintroduce this at all.

gxalpha avatar Jul 27 '22 20:07 gxalpha

A hotkey is a stop-gap solution until a better UI can be made. Many people have been using this feature, including myself, so removing it entirely is not a good idea.

cg2121 avatar Jul 27 '22 20:07 cg2121

Additionally, it's used for a workflow that OBS in general isn't really made for or good at (dynamic-ish output size)

I don't think this should be a concern because it cannot be used when outputs are active.

cg2121 avatar Jul 27 '22 20:07 cg2121

it was removed since it didn't really fit in the right-click menu, which is supposed to be for actions you'd use semi-regularly, and there wasn't an obvious place in the program where it would fit better.

I guess it is rare, then, but for me this is (or was) pretty much the only thing I ever used from that right-click menu. I'd almost always use it before starting to record a window, so I'd say it was pretty regular use for me. : )

Maybe I do things weird-like, but it certainly was useful to me (and evidently to others), and it took me a while to believe it really is gone.

Thanks!

Chiitoo avatar Aug 22 '22 05:08 Chiitoo

Closing, as this was not the desired solution. This was meant for a quick thing for v28, but obviously it was decided not to be merged. For future versions, a better UI would be desired.

cg2121 avatar Aug 25 '22 22:08 cg2121