obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

UI: Disable default path setting when file path is selected

Open tuduweb opened this issue 3 years ago • 0 comments

Description

Add path value check (whether empty) when open path/file selecting dialog, to achive only using default_path when path value is empty.

Motivation and Context

Fixes #6777 In most cases, the default_path setting should only work when the path is empty, but in current situation, it looks not work well when the path is changed to other directory or is set from empty. Beacuse the properties view (default_path argument) is not updated after changing the path.

https://github.com/obsproject/obs-studio/blob/e3f416f3fc72db49d1ba71b8423454d053a9d6bf/plugins/obs-filters/color-grade-filter.c#L392-L399

How Has This Been Tested?

in Ubuntu20 reproduce the steps mentioned in issue, it works. and other behaviors link to this WidgetInfo::PathChanged function works fine as usual.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

tuduweb avatar Jul 22 '22 21:07 tuduweb