image-source: Make maximum memory usage a source property

[an0ndev]

Description

Moves the maximum memory usage setting to a per-source configurable property. The current default of 400MB is maintained:

Motivation and Context

Partial fix for a pinned issue, #3366. A redesign is complete but needs review. This is a much more minor change that should make the current version of the slideshow source more user-friendly until the redesign can be reviewed.

How Has This Been Tested?

Tested on Ubuntu 21.10 from upstream master. Changing the limit through the UI changes the number of images that successfully load.

Types of changes

• Tweak (non-breaking change to improve existing functionality)

Checklist:

• [x] My code has been run through clang-format.
• [x] I have read the contributing document.
• [x] My code is not on the master branch.
• [x] The code has been tested.
• [x] All commit messages are properly formatted and commits squashed where appropriate.
• [x] I have included updates to all appropriate documentation. (N/A)

[an0ndev]

Per our Contributing guildelines, please make these changes:

1. Use the correct commit prefix, in this case "image-source: ".

👍🏻 done, ty for reviewing :)

[an0ndev]

Hi, if someone wouldn't mind taking a look at this again, it would be much appreciated :) I have made the requested changes and think this patch overall might alleviate some slideshow source-related spam.

[Fenrirthviti]

PRs are reviewed as time allows. We have weekly meetings to go over new and pending PRs in the order they are submitted, and in the priority and urgency we assign to them. No need to remind us, we know this is here. :)

[an0ndev]

Oh, gotcha, thank you 👍🏻 👍🏻

[TheRenegadist]

Thank you for doing this an0ndev, I'm hoping this temporary change can be implemented so I can stop using Wallpaper Engine to display fan-art slideshows because I hit the hardcoded memory limit after just a dozen or so images.

[an0ndev]

any chance somebody could review this? it causes big issues in my workflow (church services with slides), a quick look would be greatly appreciated. thank you :)

[Lain-B]

This is no longer necessary because the slideshow has been rewritten to allow as many files as you'd like: https://github.com/obsproject/obs-studio/commit/a4f2290026f579c77c0ea14f93de2647151f03ae