obs-studio
obs-studio copied to clipboard
obsproject
mac-capture: Fix #3529 - Mac Capture showing last image on window close
Description
This fixes #3529
instead of maintaining the last known image on the window capture window close, it seems to default to the desktop now.
Motivation and Context
issue #3529
How Has This Been Tested?
yes, macOS.
Types of changes
- Bug fix (non-breaking change which fixes an issue)
Checklist:
- [x] My code has been run through clang-format.
- [x] I have read the contributing document.
- [x] My code is not on the master branch.
- [x] The code has been tested.
- [x] All commit messages are properly formatted and commits squashed where appropriate.
- [x] I have included updates to all appropriate documentation.
You can include "fixes" or other closing keywords to automatically link a PR to an issue.
Please also mention the Issue in the commit message, not just the PR description.
Use "x" in the checklist items instead of asterisks.
will do, and it did link with what I had in there lol.
You can include "fixes" or other closing keywords to automatically link a PR to an issue. Please also mention the Issue in the commit message, not just the PR description. Use "x" in the checklist items instead of asterisks.
will do, and it did link with what I had in there lol.
If it was successfully linked, the "Linked issues" section on the right would show the issue and the word would be underlined with a dotted line. GitHub only parses the keywords listed in the help article that I linked. It may be struggling now since the wording in the commit was added after the fact.
You can include "fixes" or other closing keywords to automatically link a PR to an issue. Please also mention the Issue in the commit message, not just the PR description. Use "x" in the checklist items instead of asterisks.
will do, and it did link with what I had in there lol.
If it was successfully linked, the "Linked issues" section on the right would show the issue and the word would be underlined with a dotted line. GitHub only parses the keywords listed in the help article that I linked. It may be struggling now since the wording in the commit was added after the fact.
1, fix is a closing keyword and it was in the body of the PR from the start, 2, fix is now in the title, and it's still not linking. 3, according to the article you linked to " (please note that the pull request must be on the default branch)."
1, fix is a closing keyword and it was in the body of the PR from the start, 2, fix is now in the title, and it's still not linking. 3, according to the article you linked to " (please note that the pull request must be on the default branch)."
- It must be "<keyword> #<issue number>" or "<keyword> <repo owner>/<repo name>#<issue number>", exactly.
- It must be in the PR description or commit message, not the PR title.
- This means the default branch of the target repo, in this case obsproject:master.
Check other PRs in the PR list to see examples of this in action.
and it's weird how that works Because it does link
it just doesn't show it on the right, Also when merged the issues do get closed, at least on my repo with the same method of linking.
I much prefer it to be listed as a potential fix, as I said it switches to the desktop wallpaper on application close. it does not switch back automatically.
it also maintains this change after obs is relaunched,
I have yet to figure out how to get a signal from the os that a window has opened or closed,
I am not certain that this is a GOOD fix. just a potential one. hence why it was stated as such.
I much prefer it to be listed as a potential fix, as I said it switches to the desktop wallpaper on application close. it does not switch back automatically.
Do you mean just the wallpaper, or the whole desktop view as if you were using Display Capture? If it captures everything happening on the desktop, such as icons or cursor, then this probably isn't okay, because it has potential to display unwanted information.
I agree that falling back to the wallpaper probably isn't the best solution.
Just wanted to check back on this. Do we have any other options for the fallback? It sounds like falling back to wallpaper might be disagreeable
Just to check back, is there any intention to address the issues / questions brought up on this PR?
Closing due to lack of response and also some more discussion needed regarding the desired behaviour of sources to make sure it's aligned across all platforms.
