obs-studio
obs-studio copied to clipboard
obsproject
UI: Add Trovo integration
Description
Add Trovo integration so that users can connect OBS to Trovo account
Motivation and Context
Add Trovo integration. https://trovo.live.
How Has This Been Tested?
Server tested and working properly.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
- [x] My code has been run through clang-format.
- [x] I have read the contributing document.
- [x] My code is not on the master branch.
- [x] The code has been tested.
- [x] All commit messages are properly formatted and commits squashed where appropriate.
- [x] I have included updates to all appropriate documentation.
Hi there, before we review this, I had a quick question - there was some discussion on Discord about Trovo moving away from implicit grant. Has there been any progress in that area? Thanks!
Hi there, before we review this, I had a quick question - there was some discussion on Discord about Trovo moving away from implicit grant. Has there been any progress in that area? Thanks!
Trovo now supports user authentication code grant instead of implicit grant.
I have some questions about this PR.
Now we have resolved all issues and conflicts
@RytoEX I think Jim will generate this random state and add the command below at build time
-DTROVO_HASH=0 -DTROVO_CLIENTID=6W4***5wf7W4Should I replace TROVO_AUTH_URL, "https://open.trovo.live/page/login.html?client_id=6W4TpDJnE95U..." with a link like "https://obsproject.com/app-auth/trovo? action=redirect" now?
Apologies for only getting back to you now, since your message is all quoted it probably got lost in emails.
We have changed how our OAuth URLs work, we now use a define for the base, and you only need to specify the path. For example in the Twitch implementation: https://github.com/obsproject/obs-studio/blob/master/UI/auth-twitch.cpp#L25-L26 So for Trovo you'd probably want use something along the lines of
#define TROVO_AUTH_URL OAUTH_BASE_URL "v1/trovo/redirect"
#define TROVO_TOKEN_URL OAUTH_BASE_URL "v1/trovo/token"
Our server-side component is now also open source and can be found here: https://github.com/obsproject/obs-oauth-cf Updating it for Trovo support should be trivial.
