obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

UI: Add configurable prefix/suffix for Screenshots

Open WizardCM opened this issue 5 years ago • 3 comments

Description

Provides prefix & suffix configuration fields for screenshots in Settings -> Advanced, alongside Replay Buffer.

image

image

Motivation and Context

Feature parity and better ability to organise files.

Additionally, as the OBS output defaults to the Videos folder on the system, it doesn't make sense to force the user to put screenshots in there too.

How Has This Been Tested?

  1. Set a screenshot hotkey
  2. Change the prefix or suffix, Save & close the Settings dialog
  3. Press the screenshot hotkey

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [x] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

WizardCM avatar Sep 02 '20 10:09 WizardCM

Why just prefix/suffix? Why not have an entirely separate output location config for each of these?

dodgepong avatar Sep 02 '20 12:09 dodgepong

That's certainly something we could do, yeah. Replay Buffer already has a section in Settings -> Output, adding another tab/section for Screenshots would be doable. I'll have to look into how heavily the path generation functions depend on the existing shared path.

Edit: Not something that could be ready by 26 though.

WizardCM avatar Sep 02 '20 12:09 WizardCM

I have never been particularly happy about the buffer being a prefix/suffix rather than a full separate path. If we can update so all 3 are separate paths, I think that is ideal.

Fenrirthviti avatar Sep 02 '20 13:09 Fenrirthviti

I am very reluctant to accept this in the current form. Would it be possible to update this to be separate/unique paths and filenames, or should this be closed in favor of a new PR?

Fenrirthviti avatar Nov 11 '22 20:11 Fenrirthviti

That would be the ideal implementation, yes. I'll close this PR for now to give someone else the opportunity to potentially implement it.

WizardCM avatar Nov 12 '22 00:11 WizardCM